From: Junio C Hamano <gitster@pobox•com>
To: Mike Hommey <mh@glandium•org>
Cc: Antoine Pelisse <apelisse@gmail•com>,
git@vger•kernel.org,
Felipe Contreras <felipe.contreras@gmail•com>
Subject: Re: [PATCH] remote-hg: do not fail on invalid bookmarks
Date: Mon, 30 Dec 2013 11:12:19 -0800 [thread overview]
Message-ID: <xmqqha9qrw4s.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131229222433.GA31355@glandium.org> (Mike Hommey's message of "Mon, 30 Dec 2013 07:24:33 +0900")
Mike Hommey <mh@glandium•org> writes:
> On Sun, Dec 29, 2013 at 12:30:02PM +0100, Antoine Pelisse wrote:
>> Mercurial can have bookmarks pointing to "nullid" (the empty root
>> revision), while Git can not have references to it.
>> When cloning or fetching from a Mercurial repository that has such a
>> bookmark, the import will fail because git-remote-hg will not be able to
>> create the corresponding reference.
>>
>> Warn the user about the invalid reference, and continue the import,
>> instead of stopping right away.
>
> It's not invalid, it's used to indicate deleted bookmarks. (Tags have
> the same property)
So what should remote-hg behave in such a case, other than what
Antoine's change does (which is to, IIRC, warn, ignore and
continue).
next prev parent reply other threads:[~2013-12-30 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-29 11:30 [PATCH] remote-hg: do not fail on invalid bookmarks Antoine Pelisse
2013-12-29 22:24 ` Mike Hommey
2013-12-30 7:41 ` Antoine Pelisse
2013-12-30 23:22 ` Mike Hommey
2013-12-30 19:12 ` Junio C Hamano [this message]
2014-01-06 13:52 ` Torsten Bögershausen
2014-01-06 21:51 ` Antoine Pelisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqha9qrw4s.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=apelisse@gmail$(echo .)com \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mh@glandium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox