From: Junio C Hamano <gitster@pobox•com>
To: Lee Carver <Lee.Carver@servicenow•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>,
Andreas Schwab <schwab@linux-m68k•org>,
Lee Carver <leeca@pnambic•com>,
Stefano Lattarini <stefano.lattarini@gmail•com>
Subject: Re: [PATCH-v3] Allow git-filter-branch to process large repositories with lots of branches.
Date: Wed, 11 Sep 2013 09:06:59 -0700 [thread overview]
Message-ID: <xmqqhadruyu4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CE550501.19691%lee.carver@corp.service-now.com> (Lee Carver's message of "Wed, 11 Sep 2013 00:21:15 +0000")
Lee Carver <Lee.Carver@servicenow•com> writes:
> It is using the same ${tempdir} working directory that git rev-list uses
> below for the ../revs file
Ah, I missed that; then that should be safe. The patch looks sane.
Can we have your sign-off, too, please?
>
> It's normally .git-rewrite/t, following the normal working directory setup
> near line 205.
>
>>
>>>
>>> case "$filter_subdir" in
>>> "")
>>> @@ -268,7 +268,7 @@ case "$filter_subdir" in
>>> esac
>>>
>>> git rev-list --reverse --topo-order --default HEAD \
>>> - --parents --simplify-merges $rev_args "$@" > ../revs ||
>>> + --parents --simplify-merges --stdin "$@" < ../parse > ../revs ||
>>> die "Could not get the commits"
>>> commits=$(wc -l <../revs | tr -d " ")
next prev parent reply other threads:[~2013-09-11 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-07 21:03 [PATCH-v2] Allow git-filter-branch to process large repositories with lots of branches Lee Carver
2013-09-07 23:06 ` Stefano Lattarini
2013-09-10 22:55 ` [PATCH-v3] " Lee Carver
2013-09-10 23:20 ` Junio C Hamano
2013-09-11 0:21 ` Lee Carver
2013-09-11 16:06 ` Junio C Hamano [this message]
2013-09-12 17:46 ` [PATCH-v4] " Lee Carver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqhadruyu4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Lee.Carver@servicenow$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=leeca@pnambic$(echo .)com \
--cc=schwab@linux-m68k$(echo .)org \
--cc=stefano.lattarini@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox