From: Junio C Hamano <gitster@pobox•com>
To: Patrick Steinhardt <ps@pks•im>
Cc: RuanXinyu via GitGitGadget <gitgitgadget@gmail•com>,
git@vger•kernel.org, RuanXinyu <1096421257@qq•com>,
RuanXinyu <r200981113@gmail•com>
Subject: Re: [PATCH] refs: add missing remove_on_disk implementation for debug backend
Date: Fri, 24 Oct 2025 08:13:37 -0700 [thread overview]
Message-ID: <xmqqikg4qqn2.fsf@gitster.g> (raw)
In-Reply-To: <aPtCvwvNUtFXqrpv@pks.im> (Patrick Steinhardt's message of "Fri, 24 Oct 2025 11:11:27 +0200")
Patrick Steinhardt <ps@pks•im> writes:
>> Signed-off-by: Xinyu Ruan <r200981113@gmail•com>
>
> Tiny nit: typically, the author and DCO should match. But the autor is
> "RuanXinyu" whereas the DCO says "Xinyu Ruan". I don't really think that
> this is something that warrants a new version, but I wanted to point
> this out anyway so that you can fix this going forward.
It may not warrant a new version in the sense that I could tweak
while queuing, but I need to be told which between the two is the
name to be used before doing so.
I can make a guess and use the latter but it would cause me yet
another piece of extra work if I guessed incorrectly, so...
next prev parent reply other threads:[~2025-10-24 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 8:38 [PATCH] refs: add missing remove_on_disk implementation for debug backend RuanXinyu via GitGitGadget
2025-10-24 9:11 ` Patrick Steinhardt
2025-10-24 15:13 ` Junio C Hamano [this message]
2025-10-27 4:01 ` 阮新宇
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikg4qqn2.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=1096421257@qq$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=r200981113@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox