From: Junio C Hamano <gitster@pobox•com>
To: "Robin Jarry" <robin@jarry•cc>
Cc: "Phillip Wood" <phillip.wood123@gmail•com>,
git@vger•kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Tim Culverhouse" <tim@timculverhouse•com>,
"Nicolas Dichtel" <nicolas.dichtel@6wind•com>,
"Bagas Sanjaya" <bagasdotme@gmail•com>,
"Eric Sunshine" <sunshine@sunshineco•com>,
"Michael Strawbridge" <michael.strawbridge@amd•com>
Subject: Re: [PATCH] send-email: export patch counters in validate environment
Date: Tue, 11 Apr 2023 12:14:03 -0700 [thread overview]
Message-ID: <xmqqile29qpw.fsf@gitster.g> (raw)
In-Reply-To: <CRU3FHOZIRVM.3N8I4FAZ2RGO5@ringo> (Robin Jarry's message of "Tue, 11 Apr 2023 19:13:19 +0200")
"Robin Jarry" <robin@jarry•cc> writes:
> It is probably best to let git-send-email out of the picture. Since
> nothing prevents from sending multiple patch series at once, it may not
> be possible to determine the proper ordering of all these files. A dumb
> 1-based counter will be perfectly suitable.
As long as the design decision is clearly documented, I am more than
fine to make it the user's problem ;-) It is a better design between
the two, as the user knows better what their payload is.
> I can run the loop twice to determine the count of non-FIFOs and adjust
> GIT_SENDEMAIL_FILE_TOTAL accordingly.
It sounds like a reasonable way out.
Thanks.
next prev parent reply other threads:[~2023-04-11 19:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 11:47 [PATCH] send-email: export patch counters in validate environment Robin Jarry
2023-04-11 13:23 ` Phillip Wood
2023-04-11 16:28 ` Junio C Hamano
2023-04-11 17:13 ` Robin Jarry
2023-04-11 19:14 ` Junio C Hamano [this message]
2023-04-11 16:47 ` Robin Jarry
2023-04-12 9:54 ` [PATCH v2] " Robin Jarry
2023-04-12 17:53 ` Junio C Hamano
2023-04-12 18:33 ` Robin Jarry
2023-04-12 20:37 ` Junio C Hamano
2023-04-12 20:39 ` Robin Jarry
2023-04-12 21:48 ` Junio C Hamano
2023-04-12 21:45 ` [PATCH v3] " Robin Jarry
2023-04-13 13:52 ` Phillip Wood
2023-04-13 14:01 ` Robin Jarry
2023-04-14 12:58 ` Phillip Wood
2023-04-14 15:28 ` [PATCH v4] " Robin Jarry
2023-04-14 15:50 ` Robin Jarry
2023-04-14 15:52 ` [PATCH v5] " Robin Jarry
2023-04-20 19:16 ` Robin Jarry
2023-04-20 19:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqile29qpw.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=bagasdotme@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=michael.strawbridge@amd$(echo .)com \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=phillip.wood123@gmail$(echo .)com \
--cc=robin@jarry$(echo .)cc \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tim@timculverhouse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox