Subject: Re: [PATCH v2] gpg-interface: add function for converting trust level to string

From: Junio C Hamano <[email-masked]>
Date: Sat, 09 Jul 2022 22:48:21 -0700

Eric Sunshine <[email-masked]> writes:

> Given the small, fixed number of trust levels, and if the list is
> unlikely to change much in the future, I might suggest simply
> initializing the fields at compile-time rather than on-demand at
> run-time:
>
>     static struct {
>         const char *key;
>         const char *display_key;
>         enum signature_trust_level value;
>     } sigcheck_gpg_trust_level[] = {
>         { "UNDEFINED", "undefined", TRUST_UNDEFINED },
>         { "NEVER", "never", TRUST_NEVER },
>         { "MARGINAL", "marginal", TRUST_MARGINAL },
>         { "FULLY", "fully", TRUST_FULLY },
>         { "ULTIMATE", "ultimate", TRUST_ULTIMATE },
>     };

Yup, that is even better.  I wonder if we can upcase in C
preprocessor macro?  It would be wonderful if we can do so,
but for just 5 entries, we can type each token three times
just fine.