Subject: Re: [PATCH v2 3/3] config.c: free(expanded) before die(), work around GCC oddity

From: Junio C Hamano <[email-masked]>
Date: Thu, 21 Oct 2021 16:32:07 -0700

Ævar Arnfjörð Bjarmason  <[email-masked]> writes:

>  cleanup:
>  	strbuf_release(&buf);
>  	free(expanded);
> -	return ret;
> +	if (!die_depth)
> +		return ret;
> +	die(_(include_depth_advice), MAX_INCLUDE_DEPTH, path,
> +	    !cf ? "<unknown>" : cf->name ? cf->name : "the command line");
>  }

Yuck.  With or without compiler bugs, this code is too ugly to live,
isn't it?