From: Junio C Hamano <gitster@pobox•com>
To: Jiang Xin <worldhello.net@gmail•com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx•de>,
"Git List" <git@vger•kernel.org>,
"Alexander Shopov" <ash@kambanaria•org>,
"Jordi Mas" <jmas@softcatala•org>,
"Matthias Rüster" <matthias.ruester@gmail•com>,
"Jimmy Angelakos" <vyruss@hellug•gr>,
"Christopher Díaz" <christopher.diaz.riv@gmail•com>,
"Jean-Noël Avila" <jn.avila@free•fr>,
"Bagas Sanjaya" <bagasdotme@gmail•com>,
"Alessandro Menti" <alessandro.menti@alessandromenti•it>,
"Gwan-gyeong Mun" <elongbug@gmail•com>, Arusekk <arek_koz@o2•pl>,
"Daniel Santos" <hello@brighterdan•com>,
"Dimitriy Ryazantcev" <DJm00n@mail•ru>,
"Peter Krefting" <peter@softwolves•pp.se>,
"Emir SARI" <bitigchi@me•com>,
"Trần Ngọc Quân" <vnwildman@gmail•com>,
"Fangyi Zhou" <me@fangyi•io>, "Yi-Jyun Pan" <pan93412@gmail•com>,
"Jiang Xin" <zhiyou.jx@alibaba-inc•com>
Subject: Re: [PATCH 1/1] ci: new github-action for git-l10n code review
Date: Tue, 24 Aug 2021 12:06:55 -0700 [thread overview]
Message-ID: <xmqqilzuoe5s.fsf@gitster.g> (raw)
In-Reply-To: <CANYiYbHUB-1LTyqCU2eFdYB7rHYq8v-ZBtL7ZR2wERfZry8TqQ@mail.gmail.com> (Jiang Xin's message of "Tue, 24 Aug 2021 21:36:02 +0800")
Jiang Xin <worldhello.net@gmail•com> writes:
>> > One such solution could be to make the `git-po-helper` job contingent on
>> > part of the repository name. For example:
>> >
>> > git-po-helper:
>> > if: endsWith(github.repository, '/git-po')
>> > [...]
>> >
>> > would skip the job unless the target repository's name is `git-po`.
>>
>> Nice.
>>
>> Can this be made into a matter purely local to git-l10n/git-po
>> repository and not git/git repository? I am wondering if we can ee
>> if the current repository is git-l10n/git-po or its fork and run it
>> only if that is true.
>
> I have read almost all the github documents on github actions, and
> tried to find if I can use a local branch, such as "github-action" to
> hold local github-actions, but no locky.
>
> That is to say, the workflow file must be introduced to the master
> branch of “git-l10n/git-po”. As "git-l10n/git-po" is a fork of
> "git/git", the new workflow should be part of "git/git", and provide a
> way to disable it by default.
Yeah, that part I am agreeing with you. I was just wondering if we
can do better than Dscho's heuristics (the repository name ending
with /git-po) to catch git-l10n/git-po or its fork to enable the
workflow in.
next prev parent reply other threads:[~2021-08-24 19:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 16:13 [PATCH 0/1] ci: new github-action for git-l10n code review Jiang Xin
2021-08-22 16:13 ` [PATCH 1/1] " Jiang Xin
2021-08-23 6:28 ` Bagas Sanjaya
2021-08-23 6:42 ` Jiang Xin
2021-08-23 21:02 ` Johannes Schindelin
2021-08-23 21:36 ` Junio C Hamano
2021-08-24 9:27 ` Johannes Schindelin
2021-08-24 19:04 ` Junio C Hamano
2021-08-24 21:34 ` Jean-Noël AVILA
2021-08-31 1:03 ` Jiang Xin
2021-08-24 13:36 ` Jiang Xin
2021-08-24 19:06 ` Junio C Hamano [this message]
2021-08-24 13:21 ` Jiang Xin
2021-08-25 12:14 ` Johannes Schindelin
2021-08-26 2:25 ` Jiang Xin
2021-08-27 2:10 ` Jeff King
2021-08-27 2:49 ` Jiang Xin
2021-08-27 7:13 ` [PATCH v3] " Jiang Xin
2021-09-02 2:31 ` [PATCH v4 0/1] " Jiang Xin
2021-09-09 9:09 ` [PATCH v5 " Jiang Xin
2021-09-09 9:09 ` [PATCH v5 1/1] " Jiang Xin
2021-09-02 2:31 ` [PATCH v4 " Jiang Xin
2021-08-23 14:28 ` [PATCH v2 0/1] " Jiang Xin
2021-08-23 14:28 ` [PATCH v2 1/1] " Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilzuoe5s.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=DJm00n@mail$(echo .)ru \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=alessandro.menti@alessandromenti$(echo .)it \
--cc=arek_koz@o2$(echo .)pl \
--cc=ash@kambanaria$(echo .)org \
--cc=bagasdotme@gmail$(echo .)com \
--cc=bitigchi@me$(echo .)com \
--cc=christopher.diaz.riv@gmail$(echo .)com \
--cc=elongbug@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hello@brighterdan$(echo .)com \
--cc=jmas@softcatala$(echo .)org \
--cc=jn.avila@free$(echo .)fr \
--cc=matthias.ruester@gmail$(echo .)com \
--cc=me@fangyi$(echo .)io \
--cc=pan93412@gmail$(echo .)com \
--cc=peter@softwolves$(echo .)pp.se \
--cc=vnwildman@gmail$(echo .)com \
--cc=vyruss@hellug$(echo .)gr \
--cc=worldhello.net@gmail$(echo .)com \
--cc=zhiyou.jx@alibaba-inc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox