From: Junio C Hamano <gitster@pobox•com>
To: Lars Schneider <larsxschneider@gmail•com>
Cc: tboegi@web•de, Jeff King <peff@peff•net>,
Johannes Sixt <j6t@kdbg•org>,
lars.schneider@autodesk•com, git@vger•kernel.org,
patrick@luehne•de
Subject: Re: [PATCH 1/5] convert_to_git(): checksafe becomes an integer
Date: Fri, 05 Jan 2018 15:22:56 -0800 [thread overview]
Message-ID: <xmqqincfao1b.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: 96B6CD4C-0A0C-47F5-922D-B8BAFB832FD1@gmail.com
Lars Schneider <larsxschneider@gmail•com> writes:
>> On 31 Dec 2017, at 09:05, tboegi@web•de wrote:
>>
>> From: Torsten Bögershausen <tboegi@web•de>
>>
>> When calling convert_to_git(), the checksafe parameter has been used to
>> check if commit would give a non-roundtrip conversion of EOL.
>>
>> When checksafe was introduced, 3 values had been in use:
>> SAFE_CRLF_FALSE: no warning
>> SAFE_CRLF_FAIL: reject the commit if EOL do not roundtrip
>> SAFE_CRLF_WARN: warn the user if EOL do not roundtrip
>
> In general, I really like the direction as this simplifies
> my patch later on in 5/5. However, I see a few problems:
> ...
Yes, this looks like a sensible way to go. I saw Torsten's v3 for
1/5 but will end up queuing v2b, as I suspect 5/5 would need to be
adjusted for the change between the two versions.
Thanks.
next prev parent reply other threads:[~2018-01-05 23:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 15:22 [PATCH v2 0/5] convert: add support for different encodings lars.schneider
2017-12-29 15:22 ` [PATCH v2 1/5] strbuf: add xstrdup_toupper() lars.schneider
2017-12-29 15:56 ` Torsten Bögershausen
2017-12-29 16:55 ` Lars Schneider
2017-12-29 15:22 ` [PATCH v2 2/5] utf8: add function to detect prohibited UTF-16/32 BOM lars.schneider
2017-12-29 15:22 ` [PATCH v2 3/5] utf8: add function to detect a missing " lars.schneider
2017-12-29 15:22 ` [PATCH v2 4/5] convert: add support for 'checkout-encoding' attribute lars.schneider
2017-12-29 17:28 ` Torsten Bögershausen
2017-12-30 19:58 ` Lars Schneider
2017-12-29 15:22 ` [PATCH v2 5/5] convert: add tracing for checkout-encoding lars.schneider
2017-12-31 8:05 ` [PATCH 0/5] V2B: simplify convert.c/h tboegi
2017-12-31 8:05 ` [PATCH 1/5] convert_to_git(): checksafe becomes an integer tboegi
2017-12-31 12:23 ` Lars Schneider
2018-01-01 21:59 ` [PATCH v3 1/1] convert_to_git(): checksafe becomes int conv_flags tboegi
2018-01-02 19:11 ` Lars Schneider
2018-01-03 5:36 ` Torsten Bögershausen
2018-01-03 9:37 ` Lars Schneider
2018-01-05 19:00 ` Lars Schneider
2018-01-05 19:33 ` Torsten Bögershausen
2018-01-05 23:22 ` Junio C Hamano [this message]
2018-01-06 0:55 ` [PATCH 1/5] convert_to_git(): checksafe becomes an integer Lars Schneider
2017-12-31 8:05 ` [PATCH 2/5] strbuf: add xstrdup_toupper() tboegi
2017-12-31 8:05 ` [PATCH 3/5] utf8: add function to detect prohibited UTF-16/32 BOM tboegi
2017-12-31 8:05 ` [PATCH 4/5] utf8: add function to detect a missing " tboegi
2017-12-31 8:06 ` [PATCH 5/5] convert: add support for 'checkout-encoding' attribute tboegi
2018-01-05 14:45 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqincfao1b.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=lars.schneider@autodesk$(echo .)com \
--cc=larsxschneider@gmail$(echo .)com \
--cc=patrick@luehne$(echo .)de \
--cc=peff@peff$(echo .)net \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox