From: Junio C Hamano <gitster@pobox•com>
To: Kaartic Sivaraam <kaarticsivaraam91196@gmail•com>
Cc: Stefan Beller <sbeller@google•com>,
"git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: [PATCH 2/2] doc: add another way to identify if a patch has been merged
Date: Wed, 02 Aug 2017 09:01:13 -0700 [thread overview]
Message-ID: <xmqqini6dkmu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1501677122.1957.8.camel@gmail.com> (Kaartic Sivaraam's message of "Wed, 02 Aug 2017 18:02:02 +0530")
Kaartic Sivaraam <kaarticsivaraam91196@gmail•com> writes:
> On Tue, 2017-08-01 at 10:46 -0700, Stefan Beller wrote:
>> Actually I am slightly negative on this one, because of
>> occurrences like [1].
>>
>> Our SubmittingPatches is already considered *too long* for most people
>> who just want to drop a drive-by patch.
>>
>> Adding more knowledge (which btw is about general git usage and not
>> specific to our development workflow; you'd find the same tip in the
>> kernel community).
>>
>> I wonder if we need a document that describes workflows.
>> (Oh, look we have 'man gitworkflows'! I did not know)
>>
>> So maybe we want to cut a lot of workflow related commendatory from
>> the SubmitingPatches and then encourage to read such man page?
>>
> That's right. Maybe Documentation/SubmittingPatches needs a revamp to
> be one-time contributor friendly? Maybe introducing a "gist" for people
> who do not have the time to read the whole document, might be of help?
First of all, I do not think lack of one-time contributor is
something we should consider to be a problem. Supporting new
contributors so that they will be involved more in the development
process is a lot more important issue.
A new contributor will get something wrong no matter what the
documentation says. One-time contributor's intention is "I am
sending a patch this time, but I have no plan to get involved
further---I do not have time for this". It ridiculous to ask for a
patch that adds an 's' to the end of a third-party-singular verb in
the present tense to be rerolled only because the title had an extra
full-stop at the end. Practically, a patch like that by a "one time
contributor" will always have to be fixed before committing it.
I think the exchange Stefan cited was an example that we want to
have more of. The contributor is indicating that, even though the
patch could be a drive-by patch by one-timer from whom we will never
hear again, it is not--the contributor is willing to learn the way
things are done here, and showing that it is worth _our_ time to
explain the things so that the future patches will take less effort
to accept on our side.
Because we do not have a group of dedicated volunteers, it is done
by more experienced people around here but that can be done only
when they have time. I view it as a more severe problem than any
documentation. An abbreviated version of the documentation to
invite more new people means that we must be prepared to give more
high-touch onboarding help to them.
next prev parent reply other threads:[~2017-08-02 16:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 11:09 [PATCH 1/2] doc: fix small issues in SubmittingPatches Kaartic Sivaraam
2017-07-30 11:09 ` [PATCH 2/2] doc: add another way to identify if a patch has been merged Kaartic Sivaraam
2017-07-30 14:49 ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Philip Oakley
2017-07-30 16:17 ` Kaartic Sivaraam
2017-07-30 16:18 ` Kaartic Sivaraam
2017-07-31 20:23 ` Stefan Beller
2017-07-31 20:34 ` Junio C Hamano
2017-08-01 15:59 ` Kaartic Sivaraam
2017-08-01 17:38 ` Stefan Beller
2017-08-02 12:22 ` [RFC] The correct and consistent alternative to quote a command ? Kaartic Sivaraam
2017-08-02 15:37 ` Junio C Hamano
2017-08-02 17:32 ` Stefan Beller
2017-08-03 15:35 ` Kaartic Sivaraam
2017-08-01 16:05 ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Kaartic Sivaraam
2017-08-01 16:05 ` [PATCH 2/2] doc: add another way to identify if a patch has been merged Kaartic Sivaraam
2017-08-01 17:46 ` Stefan Beller
2017-08-02 12:32 ` Kaartic Sivaraam
2017-08-02 16:01 ` Junio C Hamano [this message]
2017-08-02 16:28 ` Junio C Hamano
2017-08-02 17:58 ` Stefan Beller
2017-08-07 14:34 ` Kaartic Sivaraam
2017-08-07 14:33 ` Kaartic Sivaraam
2017-08-01 21:04 ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqini6dkmu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kaarticsivaraam91196@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox