public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: git@vger•kernel.org, "Ramsay Jones" <ramsay@ramsayjones•plus.com>,
	"René Scharfe" <l.s.r@web•de>,
	"Stefan Beller" <sbeller@google•com>, "Jeff King" <peff@peff•net>,
	"Jakub Narębski" <jnareb@gmail•com>,
	"Jacob Keller" <jacob.keller@gmail•com>
Subject: Re: [PATCH v3 0/8] Better heuristics make prettier diffs
Date: Mon, 19 Sep 2016 10:27:45 -0700	[thread overview]
Message-ID: <xmqqintrg5pq.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqd1jzho2l.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 19 Sep 2016 09:05:54 -0700")

Junio C Hamano <gitster@pobox•com> writes:

> Michael Haggerty <mhagger@alum•mit.edu> writes:
>
>> On 09/08/2016 01:25 AM, Junio C Hamano wrote:
>>> I'd move it temporarily to t4061 with a separate SQUASH??? at the
>>> tip for now, as I am running out of time today.
>>
>> I didn't realize you were waiting for an ACK. Yes, it's totally OK to
>> rename the test.
>
> I actually wasn't asking for an Ack.
>
> As the issue was in the one that is buried a few commits from the
> tip, and there is a later one that adds more tests to it, I didn't
> find enough energy to rename the new file in a buried commit and
> then adjust the patch later updates it, I was hoping that you'd
> reroll to save me effort, rather than forcing me to do the rebase
> myself ;-).

Now I did, so no need to resend (unless you have changes other than
the renaming of the test script, that is).

Let's move it down to 'next' soonish.

Thanks.

next prev parent reply	other threads:[~2016-09-19 17:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05  9:44 [PATCH v3 0/8] Better heuristics make prettier diffs Michael Haggerty
2016-09-05  9:44 ` [PATCH v3 1/8] xdl_change_compact(): fix compaction heuristic to adjust ixo Michael Haggerty
2016-09-05  9:44 ` [PATCH v3 2/8] xdl_change_compact(): only use heuristic if group can't be matched Michael Haggerty
2016-09-05  9:44 ` [PATCH v3 3/8] is_blank_line(): take a single xrecord_t as argument Michael Haggerty
2016-09-05  9:44 ` [PATCH v3 4/8] recs_match(): take two xrecord_t pointers as arguments Michael Haggerty
2016-09-05  9:44 ` [PATCH v3 5/8] xdl_change_compact(): introduce the concept of a change group Michael Haggerty
2016-09-05  9:44 ` [PATCH v3 6/8] diff: improve positioning of add/delete blocks in diffs Michael Haggerty
2016-09-05  9:44 ` [PATCH v3 7/8] parse-options: add parse_opt_unknown_cb() Michael Haggerty
2016-09-05  9:44 ` [PATCH v3 8/8] blame: honor the diff heuristic options and config Michael Haggerty
2016-09-07 18:11 ` [PATCH v3 0/8] Better heuristics make prettier diffs Junio C Hamano
2016-09-07 21:21   ` Jacob Keller
2016-09-07 23:25 ` Junio C Hamano
2016-09-19  6:35   ` Michael Haggerty
2016-09-19 16:05     ` Junio C Hamano
2016-09-19 17:27       ` Junio C Hamano [this message]
2016-09-20  6:33         ` Michael Haggerty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqintrg5pq.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jacob.keller@gmail$(echo .)com \
    --cc=jnareb@gmail$(echo .)com \
    --cc=l.s.r@web$(echo .)de \
    --cc=mhagger@alum$(echo .)mit.edu \
    --cc=peff@peff$(echo .)net \
    --cc=ramsay@ramsayjones$(echo .)plus.com \
    --cc=sbeller@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox