public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Dominik Fischer <d.f.fischer@web•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH/GSoC] add a add.patch config variable
Date: Thu, 24 Mar 2016 23:30:54 -0700	[thread overview]
Message-ID: <xmqqio0b5ash.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <56F489C3.9050400@web.de> (Dominik Fischer's message of "Fri, 25 Mar 2016 01:43:47 +0100")

Dominik Fischer <d.f.fischer@web•de> writes:

> As the configuration variable can be overwritten by a command line
> option, I am tempted to amend this by replacing all occurrences of
> "git add" in other scripts with "git add --no-patch" to ensure the
> expected behavior.

Don't even think about it--you won't know all scripts you have to
fix like that, as a lot more invocations of "git add" appear in end
user's scripts that we have never seen.

  reply	other threads:[~2016-03-25  6:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 21:09 [GSoC] Proposal XZS
2016-03-24 21:09 ` [PATCH/GSoC] add a add.patch config variable XZS
2016-03-24 21:20   ` Junio C Hamano
2016-03-25  0:43     ` Dominik Fischer
2016-03-25  6:30       ` Junio C Hamano [this message]
2016-04-21  9:15         ` [PATCH/RFC/GSoC 0/2] " XZS
2016-04-21  9:15           ` [PATCH/RFC/GSoC 1/2] count recursion depth XZS
2016-04-21  9:15           ` [PATCH/RFC/GSoC 2/2] add a add.patch config variable XZS
2016-04-21 15:39           ` [PATCH/RFC/GSoC 0/2] " Johannes Schindelin
2016-04-21 16:30             ` Dominik Fischer
2016-04-21 16:43               ` Matthieu Moy
2016-04-21 16:47                 ` Junio C Hamano
2016-04-21 17:28                   ` Dominik Fischer
2016-04-22  6:45                     ` Johannes Schindelin
2016-04-22  6:42               ` Johannes Schindelin
2016-03-25  7:01   ` [PATCH/GSoC] " Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqio0b5ash.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=d.f.fischer@web$(echo .)de \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox