Subject: Re: [PATCH 01/19] mingw: let's use gettext with MSYS2

From: Junio C Hamano <[email-masked]>
Date: Sun, 24 Jan 2016 17:42:00 -0800

Johannes Schindelin <[email-masked]> writes:

> This solves two problems:
>
> - we now have proper localisation even on Windows
>
> - we sidestep the infamous "BUG: your vsnprintf is broken (returned -1)"
>   message when running "git init" (which otherwise prevents the entire
>   test suite from running)

It is unclear to me how gettext is related to use of vsnprintf().
"sidestep" hints me that perhaps we do not call vsnprintf() from
strbuf_vaddf() in a way that reveals its breakage when we are using
gettext, but I am not quite seeing how.

Because as the next sentence says, that does sound like a critical
issue not to be able to even run "init", I wanted to learn more
about the real issue.

>
> The latter issue is rather crucial, as *no* test passes in Git for
> Windows without this fix.
>
> Signed-off-by: Johannes Schindelin <[email-masked]>
> ---
>  config.mak.uname | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 4b2e1b8..6b25661 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -560,7 +560,7 @@ else
>  		NO_R_TO_GCC_LINKER = YesPlease
>  		INTERNAL_QSORT = YesPlease
>  		HAVE_LIBCHARSET_H = YesPlease
> -		NO_GETTEXT = YesPlease
> +		NO_GETTEXT =
>  		USE_LIBPCRE= YesPlease
>  		NO_CURL =
>  		USE_NED_ALLOCATOR = YesPlease