From: Junio C Hamano <gitster@pobox•com>
To: Johannes Sixt <j6t@kdbg•org>
Cc: Stefan Beller <sbeller@google•com>,
git@vger•kernel.org, peff@peff•net, jrnieder@gmail•com,
johannes.schindelin@gmail•com, Jens.Lehmann@web•de,
ericsunshine@gmail•com
Subject: Re: [PATCH 0/8] Rerolling sb/submodule-parallel-fetch for the time after 2.7
Date: Mon, 14 Dec 2015 13:00:42 -0800 [thread overview]
Message-ID: <xmqqio40iw3p.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <566F2952.8000307@kdbg.org> (Johannes Sixt's message of "Mon, 14 Dec 2015 21:40:50 +0100")
Johannes Sixt <j6t@kdbg•org> writes:
> Am 14.12.2015 um 20:37 schrieb Stefan Beller:
>> I am sending out a new version for replacing sb/submodule-parallel-fetch for
>> the time after the 2.7 release.
>>
>> The content are
>> * all patches as in the branch sb/submodule-parallel-fetch
>> * inlcuding the fixups as suggested by Hannes,
>> * write a message to the debug log for better testing and debugging purposes
>> (a patch cherry picked from the series which is supposed to build on top of this)
>>
>> The patches themselves were rebased such that there are no fixup commits
>> any more, but we get things right the first time.
>>
>> The commit message of "run-command: add an asynchronous parallel child processor"
>> has slightly been updated to mention the fact that we don't want to use waitpid(-1)
>> but rather use the assumption of child's stderr living as long as the child itself.
>
> Thanks! I rebased a version of sb/submodule-parallel-fetch that
> includes my suggested improvements, and the result is identical to
> this series except for the trace output mentioned in the last bullet
> point.
>
> With or without addressing my note about the commit message in 6/8:
>
> Acked-by: Johannes Sixt <j6t@kdbg•org>
Thanks, both. This round does look very clean to build on top.
prev parent reply other threads:[~2015-12-14 21:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 19:37 [PATCH 0/8] Rerolling sb/submodule-parallel-fetch for the time after 2.7 Stefan Beller
2015-12-14 19:37 ` [PATCH 1/8] submodule.c: write "Fetching submodule <foo>" to stderr Stefan Beller
2015-12-14 19:37 ` [PATCH 2/8] xread: poll on non blocking fds Stefan Beller
2015-12-14 22:58 ` Eric Sunshine
2015-12-14 23:07 ` Stefan Beller
2015-12-14 23:11 ` Junio C Hamano
2015-12-14 23:14 ` Stefan Beller
2015-12-14 19:37 ` [PATCH 3/8] xread_nonblock: add functionality to read from fds without blocking Stefan Beller
2015-12-14 20:59 ` Junio C Hamano
2015-12-14 23:03 ` Eric Sunshine
2015-12-14 23:05 ` Eric Sunshine
2015-12-14 23:15 ` Junio C Hamano
2015-12-14 23:57 ` Jeff King
2015-12-15 0:09 ` Stefan Beller
2015-12-15 0:16 ` Jeff King
2015-12-15 0:25 ` Stefan Beller
2015-12-15 1:44 ` Jeff King
2015-12-15 6:12 ` Johannes Sixt
2015-12-15 1:40 ` Junio C Hamano
2015-12-14 19:37 ` [PATCH 4/8] strbuf: add strbuf_read_once to read " Stefan Beller
2015-12-14 23:16 ` Eric Sunshine
2015-12-14 23:27 ` Stefan Beller
2015-12-14 19:37 ` [PATCH 5/8] sigchain: add command to pop all common signals Stefan Beller
2015-12-14 19:37 ` [PATCH 6/8] run-command: add an asynchronous parallel child processor Stefan Beller
2015-12-14 20:39 ` Johannes Sixt
2015-12-14 21:40 ` Stefan Beller
2015-12-14 19:37 ` [PATCH 7/8] fetch_populated_submodules: use new parallel job processing Stefan Beller
2015-12-14 19:37 ` [PATCH 8/8] submodules: allow parallel fetching, add tests and documentation Stefan Beller
2015-12-14 20:40 ` [PATCH 0/8] Rerolling sb/submodule-parallel-fetch for the time after 2.7 Johannes Sixt
2015-12-14 21:00 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqio40iw3p.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=ericsunshine@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=johannes.schindelin@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox