Subject: Re: [PATCH v2 08/12] initial_ref_transaction_commit(): function for initial ref creation

From: Junio C Hamano <[email-masked]>
Date: Mon, 15 Jun 2015 11:53:04 -0700

Michael Haggerty <[email-masked]> writes:

> +	struct ref_transaction *t;
> +	struct strbuf err = STRBUF_INIT;
> +
> +	t = ref_transaction_begin(&err);
> +	if (!t)
> +		die(err.buf);

Yikes, and sorry for sending three messages without consolidating
against the same patch, but

	die("%s", err.buf);

because

extern NORETURN void die(const char *err, ...) __attribute__((format (printf, 1, 2)));

in its declaration causes -Werror=format-security to barf.

Likewise for a few other instances of the same construct all in 
the same file.