public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Márcio Almada" <marcio.web2@gmail•com>
Cc: git@vger•kernel.org, "SZEDER Gábor" <szeder@ira•uka.de>
Subject: Re: [PATCH] fix global bash variable leak on __gitcompappend
Date: Wed, 08 Apr 2015 20:56:28 -0700	[thread overview]
Message-ID: <xmqqiod6ar9v.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1428471958-12339-2-git-send-email-marcio3w@gmail.com> ("Márcio Almada"'s message of "Wed, 8 Apr 2015 02:45:58 -0300")

"Márcio Almada" <marcio.web2@gmail•com> writes:

> ---
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Nicely found and corrected.  Please sign-off your patch and Cc area
experts if you can find them (I'll do that this time for you).

Thanks.

>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 661a829..1620546 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -186,7 +186,7 @@ fi
>  
>  __gitcompappend ()
>  {
> -	local i=${#COMPREPLY[@]}
> +	local x i=${#COMPREPLY[@]}
>  	for x in $1; do
>  		if [[ "$x" == "$3"* ]]; then
>  			COMPREPLY[i++]="$2$x$4"

next prev parent reply	other threads:[~2015-04-09  3:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08  5:45 [PATCH] fix global bash variable on __gitcompappend Márcio Almada
2015-04-08  5:45 ` [PATCH] fix global bash variable leak " Márcio Almada
2015-04-09  3:56   ` Junio C Hamano [this message]
2015-04-09  8:55     ` SZEDER Gábor
2015-04-09 13:52     ` Marcio Almada
2015-04-09 19:26       ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqiod6ar9v.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=marcio.web2@gmail$(echo .)com \
    --cc=szeder@ira$(echo .)uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox