From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: [PATCH 3/3] builtin/help.c: fix memory leak
Date: Tue, 10 Mar 2015 20:52:59 -0700 [thread overview]
Message-ID: <xmqqioe8ur50.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAGZ79kYSBsfbR_gH1Ur12vMpcK5S0K6wrOpMhNVvgffAb683Bw@mail.gmail.com> (Stefan Beller's message of "Tue, 10 Mar 2015 16:50:33 -0700")
Stefan Beller <sbeller@google•com> writes:
>> Hmph, does this memory belong to us, or are we peeking into the
>> cached data in the config cache layer?
>
> So alias_lookup(..) is a wrapper around git_config_string essentially
> (some more git_config_functions are involved, but we eventually reach
> git_config_string), where we have
>
> *dest = xstrdup(value);
>
> so I think we need to free that memory, as the config cache layer doesn't
> care any more.
Ah, OK, thanks.
next prev parent reply other threads:[~2015-03-11 3:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 16:58 [PATCH 1/3] connect.c: Fix memory leak Stefan Beller
2015-03-09 16:58 ` [PATCH 2/3] bundle.c: fix " Stefan Beller
2015-03-10 22:40 ` Junio C Hamano
2015-03-10 23:08 ` Stefan Beller
2015-03-10 23:17 ` Junio C Hamano
2015-03-10 23:51 ` Stefan Beller
2015-03-11 3:57 ` Junio C Hamano
2015-03-09 16:58 ` [PATCH 3/3] builtin/help.c: " Stefan Beller
2015-03-10 22:43 ` Junio C Hamano
2015-03-10 23:50 ` Stefan Beller
2015-03-11 3:52 ` Junio C Hamano [this message]
2015-03-09 19:23 ` [PATCH 1/3] connect.c: Fix " Torsten Bögershausen
2015-03-10 22:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqioe8ur50.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox