From: Junio C Hamano <gitster@pobox•com>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: Paolo Bonzini <bonzini@gnu•org>,
Git Mailing List <git@vger•kernel.org>,
Paolo Bonzini <pbonzini@redhat•com>
Subject: Re: [PATCH 0/3] request-pull: do something if $3 is passed
Date: Tue, 17 Feb 2015 13:03:10 -0800 [thread overview]
Message-ID: <xmqqiof01ca9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CA+55aFw_pKtraqwMMsqsYgF=ikShH=6ybtb7+QPr8r=77kmoVQ@mail.gmail.com> (Linus Torvalds's message of "Tue, 17 Feb 2015 12:42:40 -0800")
Linus Torvalds <torvalds@linux-foundation•org> writes:
> HEAD is not a tag. Never has been, never will be. If you want me to
> pull a tag, then you damn well should say what tag you want, not just
> randomly say HEAD.
>
> So what is it you want to do? At no point is "HEAD should resolve as a
> tag" sensible.
"HEAD should resolve as a tag" is not sensible, but "HEAD should
locally DWIM to something sensible" is still possible, no?
We could for example make the rule for unset $3 case like this,
instead of the current "missing $3 is a request to pull HEAD":
If you have one and only one signed tag that happens to point at
the commit sitting at HEAD, behave as if that tag was given as
the third argument from the command line.
Otherwise, if you are on a branch, behave as if that branch was
given as the third argument from the command line.
If you are not on any branch, error out.
next prev parent reply other threads:[~2015-02-17 21:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 18:16 [PATCH 0/3] request-pull: do something if $3 is passed Paolo Bonzini
2015-02-16 18:16 ` [PATCH 1/3] request-pull: fix expected format in tests Paolo Bonzini
2015-02-16 18:16 ` [PATCH 2/3] request-pull: use "git tag --points-at" to detect local tags Paolo Bonzini
2015-02-16 18:16 ` [PATCH 3/3] request-pull: find matching tag or branch name on remote side Paolo Bonzini
2015-02-16 19:47 ` [PATCH 0/3] request-pull: do something if $3 is passed Junio C Hamano
2015-02-17 10:12 ` Paolo Bonzini
2015-02-17 19:57 ` Junio C Hamano
2015-02-17 20:34 ` Paolo Bonzini
2015-02-17 20:42 ` Linus Torvalds
2015-02-17 20:53 ` Paolo Bonzini
2015-02-17 21:04 ` Linus Torvalds
2015-02-17 21:10 ` Paolo Bonzini
2015-02-17 21:18 ` Linus Torvalds
2015-02-18 7:11 ` Junio C Hamano
2015-02-17 21:03 ` Junio C Hamano [this message]
2015-02-17 21:08 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqiof01ca9.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=bonzini@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=pbonzini@redhat$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox