public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Alexander Kuleshov <kuleshovmail@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2] init-db: remove unused include
Date: Thu, 15 Jan 2015 11:11:53 -0800	[thread overview]
Message-ID: <xmqqiog77tae.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1421322451-1852-1-git-send-email-kuleshovmail@gmail.com> (Alexander Kuleshov's message of "Thu, 15 Jan 2015 17:47:31 +0600")

Alexander Kuleshov <kuleshovmail@gmail•com> writes:

> "cache.h" removed, because it's already included at "builtin.h"
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail•com>
> ---

Let's put this on hold.

$ git grep --all-match -l -e cache\\.h -e builtin\\.h -- \*.c

shows us there are tons, not just this one.

Also I'd like to see this discussion simmer a bit more:

  http://thread.gmane.org/gmane.comp.version-control.git/262454/focus=262499

>  builtin/init-db.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/builtin/init-db.c b/builtin/init-db.c
> index 280454a..8edef87 100644
> --- a/builtin/init-db.c
> +++ b/builtin/init-db.c
> @@ -3,7 +3,6 @@
>   *
>   * Copyright (C) Linus Torvalds, 2005
>   */
> -#include "cache.h"
>  #include "builtin.h"
>  #include "exec_cmd.h"
>  #include "parse-options.h"

     prev parent reply	other threads:[~2015-01-15 19:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 11:47 [PATCH v2] init-db: remove unused include Alexander Kuleshov
2015-01-15 19:11 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqiog77tae.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=kuleshovmail@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox