From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Kyle J. McKay" <mackyle@gmail•com>,
Git mailing list <git@vger•kernel.org>,
Scott Chacon <schacon@gmail•com>,
Johan Herland <johan@herland•net>
Subject: Re: [PATCH v2 2/2] t/t3308-notes-merge.sh: succeed with relaxed notes refs
Date: Wed, 07 Jan 2015 08:03:58 -0800 [thread overview]
Message-ID: <xmqqiogilgr5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150107011958.GA3536@peff.net> (Jeff King's message of "Tue, 6 Jan 2015 20:19:58 -0500")
Jeff King <peff@peff•net> writes:
> On Tue, Jan 06, 2015 at 02:20:33AM -0800, Junio C Hamano wrote:
>
>> The fact that "git notes merge refs/heads/master" fails is a very
>> good prevention of end-user mistakes, and this removal of test
>> demonstrates that we are dropping a valuable safety.
>
> Is it really that valuable? If it were:
>
> git notes merge master
>
> I could see somebody running that accidentally.
> ...
> But we are talking about
> somebody who is already fully-qualifying a ref (and anything unqualified
> continues to get looked up under refs/notes).
That (specifically 'merge') is not my real worry. It's the other
way around, actually.
Because expand_notes_ref() makes sure that any given notes ref is
prefixed appropriately to start with refs/notes/,
git notes --ref=refs/heads/master add ...blah...
git notes --ref=refs/tag/v1.0 add ...blah...
would be a sensible way when somebody wants to keep a forest of
notes refs, one per real ref. Wouldn't they have already been
trained to spell "refs/heads/master" when they want to refer to
refs/notes/refs/heads/master because of this?
next prev parent reply other threads:[~2015-01-07 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 8:03 [PATCH v2 0/2] Accept any notes ref Kyle J. McKay
2015-01-06 8:03 ` [PATCH v2 1/2] notes: accept any ref Kyle J. McKay
2015-01-06 8:03 ` [PATCH v2 2/2] t/t3308-notes-merge.sh: succeed with relaxed notes refs Kyle J. McKay
2015-01-06 10:20 ` Junio C Hamano
2015-01-06 12:27 ` Kyle J. McKay
2015-01-06 18:25 ` Junio C Hamano
2015-01-06 23:29 ` Kyle J. McKay
2015-01-06 23:54 ` Junio C Hamano
2015-01-07 1:27 ` Kyle J. McKay
2015-01-07 0:28 ` Johan Herland
2015-01-07 1:51 ` Kyle J. McKay
2015-01-07 16:14 ` Junio C Hamano
2015-01-07 1:19 ` Johan Herland
2015-01-07 1:19 ` Jeff King
2015-01-07 16:03 ` Junio C Hamano [this message]
2015-01-08 10:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqiogilgr5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johan@herland$(echo .)net \
--cc=mackyle@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=schacon@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox