Subject: Re: [PATCH 1/2] t4255: test am submodule with diff.submodule

From: Junio C Hamano <[email-masked]>
Date: Mon, 29 Dec 2014 07:42:01 -0800

Eric Sunshine <[email-masked]> writes:

>> +       (git am --abort || true) &&

Why (x || y)?  Is 'x' so unreliable that we do not know how should exit?
Should this be "test_must_fail git am --abort"?

>> +       (cd submodule && git rev-parse HEAD >../actual) &&

"git -C submodule rev-parse HEAD >actual" perhaps?

>> +test_expect_success 'diff.submodule unset' '
>> +       (git config --unset diff.submodule || true) &&

I think test_config and test_unconfig were invented for things like
this (same for all the other use of "git config").