From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Michael J Gruber <git@drmicha•warpmail.net>, git@vger•kernel.org
Subject: Re: [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1
Date: Tue, 02 Dec 2014 15:57:50 -0800 [thread overview]
Message-ID: <xmqqiohtli4h.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141202210753.GD23461@peff.net> (Jeff King's message of "Tue, 2 Dec 2014 16:07:53 -0500")
Jeff King <peff@peff•net> writes:
> Taking a step back, though, I am not sure I understand the reasoning
> behind the original e7f224f. The rationale in the commit message is that
> we want to make sure that the files are writable. But why would they not
> be? They are created by "cp -R",...
Wait. After doing this,
$ mkdir -p src/a && >src/b 2>src/a/c && chmod a-w src/b src/a/c
$ cp -R src dst
$ ls -lR dst
dst/b and dst/a/c are 0440 (with umask 0027, which makes src/b and
src/a/c also 0440, which is copied with "cp -R").
I was primarily worried about t/lib-gpg/* being read-only from a
src-tarball extract when we had a discussion that led to e7f224f7
(t/lib-gpg: make gpghome files writable, 2014-10-24).
next prev parent reply other threads:[~2014-12-02 23:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 23:09 [ANNOUNCE] Git v2.2.0 Junio C Hamano
2014-11-27 21:32 ` Steven Noonan
2014-11-28 4:46 ` Jeff King
2014-11-28 9:48 ` Michael J Gruber
2014-11-28 16:50 ` tests do not work with gpg 2.1 Jeff King
2014-12-02 12:55 ` Michael J Gruber
2014-12-02 13:40 ` [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1 Michael J Gruber
2014-12-02 21:07 ` Jeff King
2014-12-02 23:57 ` Junio C Hamano [this message]
2014-12-03 0:05 ` Jeff King
2014-12-03 16:21 ` Junio C Hamano
2014-12-03 11:23 ` Michael J Gruber
2014-12-03 16:45 ` Junio C Hamano
2014-12-02 21:21 ` tests do not work with gpg 2.1 Jeff King
2014-12-02 21:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqiohtli4h.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox