From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: What's cooking in git.git (Oct 2014, #08; Fri, 31)
Date: Mon, 03 Nov 2014 10:41:48 -0800 [thread overview]
Message-ID: <xmqqioiwrus3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141101040932.GC8307@peff.net> (Jeff King's message of "Sat, 1 Nov 2014 00:09:32 -0400")
Jeff King <peff@peff•net> writes:
> On Fri, Oct 31, 2014 at 01:59:20PM -0700, Junio C Hamano wrote:
>
>> --------------------------------------------------
>> [Discarded]
>>
>> * jk/tag-contains (2014-06-30) 8 commits
>> . perf: add tests for tag --contains
>> . tag: use commit_contains
>> . commit: provide a fast multi-tip contains function
>> . string-list: add pos to iterator callback
>> . add functions for memory-efficient bitmaps
>> . paint_down_to_common: use prio_queue
>> . tag: factor out decision to stream tags
>> . tag: allow --sort with -n
>>
>> Expecting a reroll.
>
> Seems reasonable. I am still planning to re-roll this eventually, but I
> do not think there is a deep need to carry it in your tree for the time
> being.
I started to think about how to consolidate the various "reachable"
and "contains" traversal machinery (and that was one reason why I
had a small clean-up patches in the merge-base machinery) but
haven't managed to allocate enough concentration on the issue (yet).
>> * jk/makefile (2014-02-05) 16 commits
>> . FIXUP
>> . move LESS/LV pager environment to Makefile
>> . Makefile: teach scripts to include make variables
>> . FIXUP
>> . Makefile: auto-build C strings from make variables
>> . Makefile: drop *_SQ variables
>> . FIXUP
>> . Makefile: add c-quote helper function
>> . Makefile: introduce sq function for shell-quoting
>> . Makefile: always create files via make-var
>> . Makefile: store GIT-* sentinel files in MAKE/
>> . Makefile: prefer printf to echo for GIT-*
>> . Makefile: use tempfile/mv strategy for GIT-*
>> . Makefile: introduce make-var helper function
>> . Makefile: fix git-instaweb dependency on gitweb
>> . Makefile: drop USE_GETTEXT_SCHEME from GIT-CFLAGS
>>
>> Simplify the Makefile rules and macros that exist primarily for
>> quoting purposes, and make it easier to robustly express the
>> dependency rules.
>>
>> Expecting a reroll.
>
> I was surprised you carried this in your tree for so long. I do like the
> direction it was going, but I was not 100% convinced that it was
> something _other_ people liked, and I never really prioritized getting
> back to it. Did you actually like it and really wanted to see it
> finished, or did just kind of hang around because you had never bothered
> to drop it?
I liked most of them (especially the LESS/LV one and a few ones on SQ).
I am not sure if I had major issues with any parts of them other
than those small FIXUPs (yeah, I no longer recall the details ;-).
prev parent reply other threads:[~2014-11-03 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 20:59 What's cooking in git.git (Oct 2014, #08; Fri, 31) Junio C Hamano
2014-11-01 4:09 ` Jeff King
2014-11-03 18:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqioiwrus3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox