public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Julien Carsique <julien.carsique@gmail•com>
Cc: "Richard Hansen" <rhansen@bbn•com>,
	git@vger•kernel.org, "SZEDER Gábor" <szeder@ira•uka.de>,
	"Felipe Contreras" <felipe.contreras@gmail•com>,
	"Ramkumar Ramachandra" <artagnon@gmail•com>,
	"Simon Oosthoek" <s.oosthoek@xs4all•nl>,
	"Eduardo R. D'Avila" <erdavila@gmail•com>
Subject: Re: [PATCH] git-prompt.sh: shorter equal upstream branch name
Date: Tue, 07 Oct 2014 13:10:30 -0700	[thread overview]
Message-ID: <xmqqiojvej49.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54340D63.8030507@gmail.com> (Julien Carsique's message of "Tue, 07 Oct 2014 17:57:23 +0200")

Julien Carsique <julien.carsique@gmail•com> writes:

> Hi,
>
> Thank you both for your feedback!
> I'm looking at applying your requests:
> - add tests,
> - variable renaming,
> - use of local,
> - fix multiple issues on string parsing
> - avoid useless bash-isms? Did you agree on the ones I should remove?
>
> I'll send an updated patch asap. Tell me if I forgot something.

I just re-read the comments in the thread, and a few things look
missing:

 - git-svn?
 - conditionally enable this feature?

Other than that the above list looks like a fairly good one.

Thanks.

next prev parent reply	other threads:[~2014-10-07 20:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 15:36 [PATCH] git-prompt.sh: shorter equal upstream branch name Julien Carsique
2014-09-30 20:44 ` Richard Hansen
2014-09-30 22:35   ` Junio C Hamano
2014-10-01  3:54     ` Richard Hansen
2014-10-01 17:49       ` Junio C Hamano
2014-10-07 15:57         ` Julien Carsique
2014-10-07 19:42           ` Richard Hansen
2014-10-07 20:10           ` Junio C Hamano [this message]
2014-09-30 22:29 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqiojvej49.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=artagnon@gmail$(echo .)com \
    --cc=erdavila@gmail$(echo .)com \
    --cc=felipe.contreras@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=julien.carsique@gmail$(echo .)com \
    --cc=rhansen@bbn$(echo .)com \
    --cc=s.oosthoek@xs4all$(echo .)nl \
    --cc=szeder@ira$(echo .)uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox