From: Junio C Hamano <gitster@pobox•com>
To: Karsten Blees <karsten.blees@gmail•com>
Cc: Tanay Abhra <tanayabh@gmail•com>,
Eric Sunshine <sunshine@sunshineco•com>,
Git List <git@vger•kernel.org>,
Ramkumar Ramachandra <artagnon@gmail•com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Subject: Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string
Date: Mon, 30 Jun 2014 10:52:52 -0700 [thread overview]
Message-ID: <xmqqioniz3m3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53B1889D.3010506@gmail.com> (Karsten Blees's message of "Mon, 30 Jun 2014 17:56:13 +0200")
Karsten Blees <karsten.blees@gmail•com> writes:
> Which may not be too harmful in some cases, but if a user changes:
>
> gc.pruneexpire=4.weeks.ago
>
> to
>
> gc.pruneexpire=4.monhts.ago
>
> (note the typo), the next git-gc will warn the user and then happily throw
> away data that the user intended to keep (default is 2.weeks.ago).
>
> Thus I think git should die() if it encounters an invalid config setting.
Yes but not at the parsing time. Only when we are about to _use_
the value for pruneexpire as a time duration we should die of the
error. Diagnosing an error early is a separate matter, but if the
operation does not care about the typo we shouldn't die.
next prev parent reply other threads:[~2014-06-30 17:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 10:41 [RFC/PATCH V2] alias.c: replace git_config with git_config_get_string Tanay Abhra
2014-06-23 10:41 ` [RFC/PATCH V2] branch.c: " Tanay Abhra
2014-06-25 4:45 ` Eric Sunshine
2014-06-26 8:09 ` Tanay Abhra
2014-06-29 11:06 ` Eric Sunshine
2014-06-23 10:41 ` [RFC/PATCH] imap-send.c: " Tanay Abhra
2014-06-25 7:09 ` Eric Sunshine
2014-06-26 8:14 ` Tanay Abhra
2014-06-26 16:50 ` Matthieu Moy
2014-06-26 23:57 ` Karsten Blees
2014-06-23 10:41 ` [RFC/PATCH] notes-util.c: " Tanay Abhra
2014-06-25 7:54 ` Eric Sunshine
2014-06-26 8:19 ` Tanay Abhra
2014-06-29 11:01 ` Eric Sunshine
2014-06-30 13:34 ` Karsten Blees
2014-06-30 14:32 ` Eric Sunshine
2014-06-30 14:54 ` Karsten Blees
2014-06-30 14:39 ` Tanay Abhra
2014-06-30 15:56 ` Karsten Blees
2014-06-30 16:21 ` Tanay Abhra
2014-06-30 17:52 ` Junio C Hamano [this message]
2014-07-01 8:36 ` Matthieu Moy
2014-06-23 10:41 ` [RFC/PATCH] notes.c: " Tanay Abhra
2014-06-25 8:06 ` Eric Sunshine
2014-06-26 8:20 ` Tanay Abhra
2014-06-23 10:41 ` [RFC/PATCH] pager.c: " Tanay Abhra
2014-06-25 3:59 ` Eric Sunshine
2014-06-26 8:24 ` Tanay Abhra
2014-06-26 18:46 ` Karsten Blees
2014-06-27 11:55 ` Matthieu Moy
2014-06-27 16:57 ` Karsten Blees
2014-06-27 19:19 ` Matthieu Moy
2014-06-28 5:20 ` Karsten Blees
2014-06-28 6:01 ` Matthieu Moy
2014-06-28 14:29 ` Karsten Blees
2014-06-29 12:04 ` Matthieu Moy
2014-06-23 22:38 ` [RFC/PATCH V2] alias.c: " Jonathan Nieder
2014-06-24 1:50 ` Tanay Abhra
2014-06-25 2:12 ` Eric Sunshine
2014-06-26 8:24 ` Tanay Abhra
2014-06-26 16:39 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqioniz3m3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karsten.blees@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox