public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Christian Couder <chriscool@tuxfamily•org>
Cc: git@vger•kernel.org, Philip Oakley <philipoakley@iee•org>,
	Thomas Rast <trast@inf•ethz.ch>, Johannes Sixt <j6t@kdbg•org>,
	Eric Sunshine <sunshine@sunshineco•com>,
	Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH v5 1/7] replace: forbid replacing an object with one of a different type
Date: Fri, 06 Sep 2013 14:34:18 -0700	[thread overview]
Message-ID: <xmqqioydws6d.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqmwnpwv6m.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Fri, 06 Sep 2013 13:29:21 -0700")

Junio C Hamano <gitster@pobox•com> writes:

> Christian Couder <chriscool@tuxfamily•org> writes:
>
>> +	obj_type = sha1_object_info(object, NULL);
>> +	repl_type = sha1_object_info(repl, NULL);
>
> That we can do this is somewhat curious....

Note that this was a comment on the sha1_object_info() API, which,
unlike read_sha1_file() API, does not seem to interact with the
"replace" mechanism.  I _think_ that needs to be rethought by
checking each call site, but for the purpose of this series, I think
this is the best we can do in this patch.

Will queue the whole series.

Thanks.

next prev parent reply	other threads:[~2013-09-06 21:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06  5:10 [PATCH v5 0/7] Check replacement object type and minor updates Christian Couder
2013-09-06  5:10 ` [PATCH v5 1/7] replace: forbid replacing an object with one of a different type Christian Couder
2013-09-06 20:29   ` Junio C Hamano
2013-09-06 21:34     ` Junio C Hamano [this message]
2013-09-06  5:10 ` [PATCH v5 2/7] Documentation/replace: state that objects must be of the same type Christian Couder
2013-09-06  5:10 ` [PATCH v5 3/7] t6050-replace: test that objects are " Christian Couder
2013-09-06  5:10 ` [PATCH v5 4/7] t6050-replace: add test to clean up all the replace refs Christian Couder
2013-09-06  5:10 ` [PATCH v5 5/7] Documentation/replace: add Creating Replacement Objects section Christian Couder
2013-09-06  5:10 ` [PATCH v5 6/7] replace: allow long option names Christian Couder
2013-09-06  5:10 ` [PATCH v5 7/7] t6050-replace: use some " Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqioydws6d.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=chriscool@tuxfamily$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=j6t@kdbg$(echo .)org \
    --cc=jrnieder@gmail$(echo .)com \
    --cc=philipoakley@iee$(echo .)org \
    --cc=sunshine@sunshineco$(echo .)com \
    --cc=trast@inf$(echo .)ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox