Subject: Re: [PATCH 1/2] remote: allow `guess_remote_head()` to suppress advice

From: Junio C Hamano <[email-masked]>
Date: Fri, 21 Mar 2025 01:52:54 -0700

Patrick Steinhardt <[email-masked]> writes:

> On Wed, Mar 19, 2025 at 08:46:45PM -0500, Justin Tobler wrote:
>> diff --git a/remote.h b/remote.h
>> index 6be5031f64..49c7b644bb 100644
>> --- a/remote.h
>> +++ b/remote.h
>> @@ -395,7 +395,7 @@ struct ref *get_local_heads(void);
>>   */
>>  struct ref *guess_remote_head(const struct ref *head,
>>  			      const struct ref *refs,
>> -			      int all);
>> +			      int all, int quiet);
>
> I think instead of introducing another boolean parameter it would be
> preferable to have a preparatory commit that turns `all` into `flags`.

Good.  And when we turn that into a set of bits "flags", make sure
we make it unsigned, not signed int.

Thanks.