From: Junio C Hamano <gitster@pobox•com>
To: Patrick Steinhardt <ps@pks•im>
Cc: Abhijeet Sonar <abhijeet.nkt@gmail•com>,
git@vger•kernel.org, me@ttaylorr•com,
sandals@crustytoothpaste•net
Subject: Re: [PATCH v6 0/2] show-index: fix uninitialized hash function
Date: Mon, 16 Dec 2024 08:21:20 -0800 [thread overview]
Message-ID: <xmqqjzbz7g5b.fsf@gitster.g> (raw)
In-Reply-To: <Z1_gnA2kwRSyCF02@pks.im> (Patrick Steinhardt's message of "Mon, 16 Dec 2024 09:11:08 +0100")
Patrick Steinhardt <ps@pks•im> writes:
> On Sat, Nov 09, 2024 at 02:57:37PM +0530, Abhijeet Sonar wrote:
>> That makes sense, applied.
>>
>> Abhijeet Sonar (2):
>> show-index: fix uninitialized hash function
>> t5300: add test for 'show-index --object-format'
>>
>> builtin/show-index.c | 9 +++++++++
>> t/t5300-pack-object.sh | 18 ++++++++++++++++++
>> 2 files changed, 27 insertions(+)
>>
>> Range-diff against v5:
>> 1: 05ee1e2ea5 = 1: 05ee1e2ea5 show-index: fix uninitialized hash function
>> 2: c8a28aae55 ! 2: 778f3ca18e t5300: add test for 'show-index --object-format'
>> @@ t/t5300-pack-object.sh: test_expect_success SHA1 'show-index works OK outside a
>>
>> +for hash in sha1 sha256
>> +do
>> -+ test_expect_success 'setup: show-index works OK outside a repository with hash algo passed in via --object-format' '
>> -+ git init explicit-hash-$hash --object-format=$hash &&
>> -+ test_commit -C explicit-hash-$hash one &&
>> -+
>> -+ cat >in <<-EOF &&
>> -+ $(git -C explicit-hash-$hash rev-parse one)
>> -+ EOF
>> -+
>> -+ git -C explicit-hash-$hash pack-objects explicit-hash-$hash <in
>> -+ '
>> -+
>> + test_expect_success 'show-index works OK outside a repository with hash algo passed in via --object-format' '
>> ++ test_when_finished "rm -rf explicit-hash-$hash" &&
>> ++ git init --object-format=$hash explicit-hash-$hash &&
>> ++ test_commit -C explicit-hash-$hash one &&
>> ++ git -C explicit-hash-$hash rev-parse one >in &&
>> ++ git -C explicit-hash-$hash pack-objects explicit-hash-$hash <in &&
>> + idx=$(echo explicit-hash-$hash/explicit-hash-$hash*.idx) &&
>> + nongit git show-index --object-format=$hash <"$idx" >actual &&
>> -+ test_line_count = 1 actual &&
>> -+
>> -+ rm -rf explicit-hash-$hash
>> ++ test_line_count = 1 actual
>> + '
>> +done
>> +
>
> Thanks, this version looks good to me.
Thanks, both. Let me mark it for 'next', then.
next prev parent reply other threads:[~2024-12-16 16:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 14:23 [PATCH] show-index: fix uninitialized hash function Abhijeet Sonar
2024-07-12 15:35 ` Junio C Hamano
2024-07-15 10:23 ` [PATCH v2] " Abhijeet Sonar
2024-07-15 16:22 ` Re* " Junio C Hamano
2024-10-26 12:09 ` [PATCH v3] " Abhijeet Sonar
2024-10-28 0:10 ` Taylor Blau
2024-10-28 5:35 ` Patrick Steinhardt
2024-10-28 17:42 ` Taylor Blau
2024-11-01 17:28 ` [PATCH v4] " Abhijeet Sonar
2024-11-02 10:29 ` Junio C Hamano
2024-11-02 16:26 ` Abhijeet Sonar
2024-11-04 19:29 ` [PATCH v5 0/2] " Abhijeet Sonar
2024-11-04 19:29 ` [PATCH v5 1/2] " Abhijeet Sonar
2024-11-04 19:29 ` [PATCH v5 2/2] t5300: add test for 'show-index --object-format' Abhijeet Sonar
2024-11-05 1:19 ` Junio C Hamano
2024-11-09 9:27 ` [PATCH v6 0/2] show-index: fix uninitialized hash function Abhijeet Sonar
2024-11-09 9:27 ` [PATCH v6 1/2] " Abhijeet Sonar
2024-11-09 9:27 ` [PATCH v6 2/2] t5300: add test for 'show-index --object-format' Abhijeet Sonar
2024-11-11 3:16 ` [PATCH v6 0/2] show-index: fix uninitialized hash function Junio C Hamano
2024-12-16 8:11 ` Patrick Steinhardt
2024-12-16 16:21 ` Junio C Hamano [this message]
2024-10-29 11:54 ` [PATCH v3] " Abhijeet Sonar
2024-10-29 10:30 ` Abhijeet Sonar
2024-10-26 12:17 ` Re* [PATCH v2] " Abhijeet Sonar
2024-07-15 22:07 ` brian m. carlson
2024-07-15 10:31 ` [PATCH] " Abhijeet Sonar
2024-07-12 16:53 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzbz7g5b.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=abhijeet.nkt@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=me@ttaylorr$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox