Subject: Re: [PATCH 26/32] object-file-convert: Implement convert_object_file_{begin,step,end}

From: Junio C Hamano <[email-masked]>
Date: Sun, 10 Sep 2023 23:28:01 -0700

"Eric W. Biederman" <[email-masked]> writes:

> +	const struct git_hash_algo *from = state->from;
> +	const struct git_hash_algo *to = state->to;
> +	struct strbuf *out = state->outbuf;
> +	const char *buffer = state->buf;
> +	size_t payload_size, size = state->buf_len;;

The excess ';' at the end is an empty statment, hence ...

> +	struct object_id oid;
>  	const char *p;
> +	int ret = 0;

... these three violate our "no declaration after statement" house rule.