From: Junio C Hamano <gitster@pobox•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: Takashi Iwai <tiwai@suse•de>,
Git Mailing List <git@vger•kernel.org>,
Andreas Stieger <astieger@suse•com>
Subject: Re: [PATCH] hash: Allow building with the external sha1dc library
Date: Mon, 31 Jul 2017 15:28:11 -0700 [thread overview]
Message-ID: <xmqqk22ogs1w.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACBZZX7M=H8tNkZXpHBvv0rbY58EJk4dkoUzGKMftWoKUqF8sA@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 28 Jul 2017 18:04:18 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
> So the upstream library expects you (and it's documented in their README) to do:
>
> #include <sha1dc/sha1.h>
>
> But your patch is just doing:
>
> #include <sha1.h>
>
> At best this seems like a trivial bug and at worst us encoding some
> Suse-specific packaging convention in git, since other distros would
> presumably want to package this in /usr/include/sha1dc/sha1.h as
> upstream suggests. I.e. using the ambiguous sha1.h name is not
> something upstream's doing by default, it's something you're doing in
> your package.
It seems there still needs a bit more work on this patch. Thanks
for reviewing and pointing out what needs to be addressed.
next prev parent reply other threads:[~2017-07-31 22:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 5:57 [PATCH] hash: Allow building with the external sha1dc library Takashi Iwai
2017-07-25 19:06 ` Junio C Hamano
2017-07-28 15:58 ` Ævar Arnfjörð Bjarmason
2017-07-28 16:04 ` Ævar Arnfjörð Bjarmason
2017-07-31 22:28 ` Junio C Hamano [this message]
2017-08-01 5:52 ` Takashi Iwai
2017-08-12 0:42 ` Junio C Hamano
2017-08-12 6:50 ` Takashi Iwai
2017-08-01 5:46 ` Takashi Iwai
2017-08-01 15:56 ` Junio C Hamano
2017-08-01 16:12 ` Takashi Iwai
2017-08-01 19:55 ` Ævar Arnfjörð Bjarmason
2017-08-01 20:50 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk22ogs1w.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=astieger@suse$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tiwai@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox