From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: Re attr API further revamp
Date: Mon, 13 Jun 2016 14:54:56 -0700 [thread overview]
Message-ID: <xmqqk2hsbvpr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kYy4ic1nYgPEHLCfoUZYkzPw3bBq+8kTyRi13nNwQHGFw@mail.gmail.com> (Stefan Beller's message of "Mon, 13 Jun 2016 14:31:18 -0700")
Stefan Beller <sbeller@google•com> writes:
> On Mon, Jun 13, 2016 at 1:55 PM, Junio C Hamano <gitster@pobox•com> wrote:
>> I hate to be doing this, but we need yet another revamp to the attr
>> API that affects all the callers.
>
> So you don't mean origin/jc/attr-more by this?
Not really; the tip of attr-more needs to be discarded after this
realization, but otherwise there is no API revamping in what is
queued on that topic.
> (Given that we have jc/attr and jc/attr-more, the third thing could go
> with jc/even-more-attr. Though I do not propose that)
The latter was merely because I couldn't rewind and rebuild the
former during the pre-release freeze. The fixup! in the latter will
be squashed into the former, etc...
>> static struct git_attr_check *ccheck;
>> const char *values[NUM_ATTRS];
>>
>> git_attr_check_initl(&ccheck, "crlf", "ident", ..., NULL);
>> git_attr_check(path, ccheck, values);
>
> and later on each thread will do a
This will have to do nothing; it is "static", and will be held to
the end of the lifetime of the program.
You _can_ allocate the check structure per thread and free them when
thread exits, but the usage pattern that appear in convert.c is
oblivious to the threading.
prev parent reply other threads:[~2016-06-13 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 20:55 Re attr API further revamp Junio C Hamano
2016-06-13 21:31 ` Stefan Beller
2016-06-13 21:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2hsbvpr.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox