From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Jonathan Nieder <jrnieder@gmail•com>,
Jacob Keller <jacob.e.keller@intel•com>,
git@vger•kernel.org, Mark Strapetz <marc.strapetz@syntevo•com>,
Stefan Beller <sbeller@google•com>,
Jacob Keller <jacob.keller@gmail•com>
Subject: Re: [PATCH] git_config_push_parameter: handle empty GIT_CONFIG_PARAMETERS
Date: Tue, 22 Mar 2016 13:29:28 -0700 [thread overview]
Message-ID: <xmqqk2kugst3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160322195051.GA20563@sigill.intra.peff.net> (Jeff King's message of "Tue, 22 Mar 2016 15:50:51 -0400")
Jeff King <peff@peff•net> writes:
> Obviously another option would be to make the parsing side more liberal
> (which has the added effect that if anybody _else_ ever wants to
> generate $GIT_CONFIG_PARAMETERS, they will not get annoyed). But I took
> this route for now because it's the simplest way to fix the regression.
> And even if we do later make the parser more liberal, it's still a good
> idea to keep the output from the generating side as clean as possible.
Sounds sensible. Will queue. Thanks.
> I just did this on master, and it is standalone. But for the reasons
> above I think it would also be fine to stick on the tip of the
> jk/submodule-c-credential topic.
Yup, I think that is fine.
next prev parent reply other threads:[~2016-03-22 20:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 22:58 [PATCH v6 0/7] submodule--helper credential.* pass into submodule Jacob Keller
2016-02-29 22:58 ` [PATCH v6 1/7] t/lib-httpd: load mod_unixd Jacob Keller
2016-02-29 22:58 ` [PATCH v6 2/7] submodule: don't pass empty string arguments to submodule--helper clone Jacob Keller
2016-02-29 23:14 ` Stefan Beller
2016-02-29 22:58 ` [PATCH v6 3/7] submodule: check argc count for git " Jacob Keller
2016-02-29 23:14 ` Stefan Beller
2016-02-29 22:58 ` [PATCH v6 4/7] submodule: fix submodule--helper clone usage Jacob Keller
2016-02-29 23:15 ` Stefan Beller
2016-02-29 22:58 ` [PATCH v6 5/7] submodule: fix segmentation fault in submodule--helper clone Jacob Keller
2016-02-29 23:20 ` Stefan Beller
2016-02-29 23:36 ` Jacob Keller
2016-02-29 22:58 ` [PATCH v6 6/7] quote: implement sq_quotef() Jacob Keller
2016-02-29 22:58 ` [PATCH v6 7/7] git: submodule honor -c credential.* from command line Jacob Keller
2016-02-29 23:39 ` Stefan Beller
2016-02-29 23:44 ` Jacob Keller
2016-03-01 1:36 ` Jeff King
2016-03-01 17:26 ` Junio C Hamano
2016-03-01 18:05 ` Jacob Keller
2016-03-01 19:07 ` Junio C Hamano
2016-03-01 22:03 ` Jacob Keller
2016-03-22 18:56 ` Jonathan Nieder
2016-03-22 19:23 ` Jeff King
2016-03-22 19:50 ` [PATCH] git_config_push_parameter: handle empty GIT_CONFIG_PARAMETERS Jeff King
2016-03-22 20:29 ` Junio C Hamano [this message]
2016-03-22 21:43 ` Jonathan Nieder
2016-03-23 0:14 ` Jacob Keller
2016-03-23 20:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2kugst3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jacob.keller@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=marc.strapetz@syntevo$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox