From: Junio C Hamano <gitster@pobox•com>
To: David Turner <dturner@twopensource•com>
Cc: git@vger•kernel.org, Anatole Shaw <git-devel@omni•poc.net>
Subject: Re: [PATCH] unpack-trees: don't update files flagged for deletion
Date: Fri, 17 Jul 2015 13:05:19 -0700 [thread overview]
Message-ID: <xmqqk2ty1reo.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1437162532-31933-1-git-send-email-dturner@twopensource.com> (David Turner's message of "Fri, 17 Jul 2015 15:48:52 -0400")
David Turner <dturner@twopensource•com> writes:
> Don't update files in the worktree from cache entries which are
> flagged with CE_WT_REMOVE. This is fixes merges in sparse
> checkouts.
s/This is/This/;
But more importantly, what is missing is "why" it is a good fix.
i.e. things like:
- why is it wrong to update what is marked with CE_UPDATE bit to be
updated in the working tree when CE_WT_REMOVE bit is on?
- how that incorrect operation breaks which operation in what way?
- how does the changed code fix that breakage?
next prev parent reply other threads:[~2015-07-17 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 19:48 [PATCH] unpack-trees: don't update files flagged for deletion David Turner
2015-07-17 20:05 ` Junio C Hamano [this message]
2015-07-17 21:19 ` [PATCH v2] unpack-trees: don't update files with CE_WT_REMOVE set David Turner
2015-07-17 21:34 ` Junio C Hamano
2015-07-18 8:37 ` Duy Nguyen
2015-07-18 21:20 ` Junio C Hamano
2015-07-21 20:52 ` Junio C Hamano
2015-07-20 17:40 ` David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2ty1reo.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dturner@twopensource$(echo .)com \
--cc=git-devel@omni$(echo .)poc.net \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox