From: Junio C Hamano <gitster@pobox•com>
To: Lex Spoon <lex@lexspoon•org>
Cc: Luke Diamand <luke@diamand•org>, Git Users <git@vger•kernel.org>
Subject: Re: [PATCHv2 3/3] git-p4: fixing --changes-block-size handling
Date: Mon, 08 Jun 2015 09:02:22 -0700 [thread overview]
Message-ID: <xmqqk2vecho1.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CALM2SnZShkETQoQuNc8e0GsPWzODQACzwjh1qCGeajiN+5sjaw@mail.gmail.com> (Lex Spoon's message of "Sun, 7 Jun 2015 18:58:15 -0400")
Lex Spoon <lex@lexspoon•org> writes:
> Unless I am reading something wrong, the "new_changes" variable could
> be dropped now. It was needed for the -m version for detecting the
> smallest change number that was returned. Otherwise it looks good to
> me.
Meaning that I should squash this in to 3/3, right?
diff --git a/git-p4.py b/git-p4.py
index f201f52..7009766 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -780,10 +780,8 @@ def p4ChangesForPaths(depotPaths, changeRange, block_size):
cmd = ['changes']
cmd += ["%s...@%d,%d" % (p, changeStart, end)]
- new_changes = []
for line in p4_read_pipe_lines(cmd):
changeNum = int(line.split(" ")[1])
- new_changes.append(changeNum)
changes[changeNum] = True
if end >= changeEnd:
--
2.4.3-495-gcb7a0d9
next prev parent reply other threads:[~2015-06-08 16:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-07 10:21 [PATCHv1 0/3] git-p4: fixing --changes-block-size support Luke Diamand
2015-06-07 10:21 ` [PATCHv1 1/3] git-p4: additional testing of --changes-block-size Luke Diamand
2015-06-07 16:06 ` Lex Spoon
2015-06-07 10:21 ` [PATCHv1 2/3] git-p4: test with limited p4 server results Luke Diamand
2015-06-07 16:11 ` Lex Spoon
2015-06-07 10:21 ` [PATCHv1 3/3] git-p4: fixing --changes-block-size handling Luke Diamand
2015-06-07 16:33 ` Lex Spoon
2015-06-07 17:06 ` Luke Diamand
2015-06-07 21:35 ` [PATCHv2 0/3] " Luke Diamand
2015-06-07 21:35 ` [PATCHv2 1/3] git-p4: additional testing of --changes-block-size Luke Diamand
2015-06-07 21:35 ` [PATCHv2 2/3] git-p4: test with limited p4 server results Luke Diamand
2015-06-07 21:35 ` [PATCHv2 3/3] git-p4: fixing --changes-block-size handling Luke Diamand
2015-06-07 22:58 ` Lex Spoon
2015-06-08 16:02 ` Junio C Hamano [this message]
2015-06-08 16:36 ` Lex Spoon
[not found] ` <xmqqy4juazkz.fsf@gitster.dls.corp.google.com>
[not found] ` <5575E264.6040601@diamand.org>
2015-06-08 22:32 ` Junio C Hamano
2015-06-07 16:01 ` [PATCHv1 0/3] git-p4: fixing --changes-block-size support Lex Spoon
2015-06-07 16:58 ` Luke Diamand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2vecho1.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=lex@lexspoon$(echo .)org \
--cc=luke@diamand$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox