Subject: Re: [PATCH v2 3/3] http-backend: spool ref negotiation requests to buffer

From: Junio C Hamano <[email-masked]>
Date: Mon, 25 May 2015 20:43:08 -0700

Jeff King <[email-masked]> writes:

> Whoops, yeah, it was just for debugging. I missed that one when sending
> out the patch.
>
> Junio, the squashable patch is below (on jk/http-backend-deadlock-2.2),
> and it looks like nothing has hit "next" yet. But you did do some
> up-merging of the topic. Let me know if you would prefer to just have a
> patch on top.

Sorry, I missed that, too (actually I saw warning() and said "Heh,
OK", without realizing that this is a normal return path).

Thanks.

>
> diff --git a/http-backend.c b/http-backend.c
> index d1333b8..6bf139b 100644
> --- a/http-backend.c
> +++ b/http-backend.c
> @@ -295,7 +295,6 @@ static ssize_t read_request(int fd, unsigned char **out)
>  		len += cnt;
>  		if (len < alloc) {
>  			*out = buf;
> -			warning("request size was %lu", (unsigned long)len);
>  			return len;
>  		}
>  
>
> -Peff