From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Duy Nguyen <pclouds@gmail•com>, Noel Grandin <noel@peralex•com>,
git <git@vger•kernel.org>
Subject: Re: feature request: excluding files/paths from "git grep"
Date: Wed, 25 Feb 2015 10:33:53 -0800 [thread overview]
Message-ID: <xmqqk2z5on72.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150225143116.GA13567@peff.net> (Jeff King's message of "Wed, 25 Feb 2015 09:31:16 -0500")
Jeff King <peff@peff•net> writes:
> If it's an attribute of the file, and not the request, maybe
> gitattributes would be a better fit. You can already do this with:
>
> *.foo -diff
>
> in your .gitattributes file, though that _also_ marks the files as "not
> for diffing", which may not be desired. There's not a separate "grep"
> attribute, but I do not think it would be unreasonable to add one.
I have a vague recollection of having a discussion that started with
something like this:
"diff" is named as if it is only for "diff" for historical
reasons, but it is about "do we want to treat its raw contents
as text?"
I do not recall its conclusion, but it it were "Yes, that is what it
means", then it might be reasonable to:
- have "git grep" ignore paths marked with -diff by default
(perhaps "-a" option to disable, just like GNU)
- have "git grep" pay attention to diff.textconv and search in the
result of textconv filter.
next prev parent reply other threads:[~2015-02-25 18:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 12:23 feature request: excluding files/paths from "git grep" Noel Grandin
2015-02-25 13:46 ` Duy Nguyen
2015-02-25 14:31 ` Jeff King
2015-02-25 18:33 ` Junio C Hamano [this message]
2015-02-25 18:51 ` Jeff King
2015-02-25 19:01 ` Junio C Hamano
2015-02-25 19:11 ` Jeff King
2015-02-26 11:16 ` Michael J Gruber
2015-02-26 11:58 ` Duy Nguyen
2015-02-26 20:59 ` Junio C Hamano
2015-02-27 15:13 ` Michael J Gruber
2015-02-27 19:17 ` Junio C Hamano
2015-02-27 10:04 ` Trevor Saunders
2015-03-01 3:06 ` Junio C Hamano
2015-03-01 13:03 ` Trevor Saunders
2015-03-01 23:22 ` Junio C Hamano
2015-03-02 12:50 ` Trevor Saunders
2015-03-04 11:25 ` Noel Grandin
2015-03-04 20:56 ` Junio C Hamano
2015-03-05 5:22 ` Jeff King
2015-03-05 6:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2z5on72.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=noel@peralex$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox