public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jonathon Mah <me@jonathonmah•com>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>
Subject: Re: [PATCHv4] sha1_file: fix iterating loose alternate objects
Date: Mon, 02 Feb 2015 12:00:17 -0800	[thread overview]
Message-ID: <xmqqk300t772.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <4727F1DC-2FC3-49BE-8C6D-0C4D7D8B107C@jonathonmah.com> (Jonathon Mah's message of "Mon, 2 Feb 2015 10:48:12 -0800")

Jonathon Mah <me@jonathonmah•com> writes:

> +test_expect_success 'prune: handle alternate object database' '
> +	test_create_repo A &&
> +		(cd A &&
> +		echo "Hello World" >file1 &&
> +		git add file1 &&
> +		git commit -m "Initial commit" file1) &&
> +	git clone -s A B &&
> +		(cd B &&
> +		echo "foo bar" >file2 &&
> +		git add file2 &&
> +		git commit -m "next commit" file2 &&
> +		git prune)
> +'

The issue does not have much to do with introducing new path to the
cloned repository, or the original having any specific content for
that matter, so I am tempted to simplify the above to something like
this intead:

	test_create_repo A &&
	git -C A commit --allow-empty -m "initial commit" &&
	git clone --shared A B &&
	git -C B commit --allow-empty -m "next commit" &&
	git -C B prune

Thanks.

next prev parent reply	other threads:[~2015-02-02 20:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 18:48 [PATCHv4] sha1_file: fix iterating loose alternate objects Jonathon Mah
2015-02-02 18:50 ` Jeff King
2015-02-02 19:35   ` Junio C Hamano
2015-02-02 20:00 ` Junio C Hamano [this message]
2015-02-02 20:02   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk300t772.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=me@jonathonmah$(echo .)com \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox