From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Jason Pyeron <jpyeron@pdinc•us>, git@vger•kernel.org
Subject: Re: Proper plumbing for porcelain gpg formats on git show?
Date: Fri, 16 Jan 2015 11:52:50 -0800 [thread overview]
Message-ID: <xmqqk30m1p0t.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150116192947.GD29365@google.com> (Jonathan Nieder's message of "Fri, 16 Jan 2015 11:29:47 -0800")
Jonathan Nieder <jrnieder@gmail•com> writes:
>> would there be interest in accepting a patch for
>>
>> %Gs - the raw GPG text from the commit
>> %Gf - the key fingerprint
>
> There may be bikeshedding on the exact format specifier, but aside
> from that I don't see why not. ;-)
I was about to say "As long as the execution is good, why not?
Spawning an extra process 'gpg --list-packets' is not quite
acceptable without properly being lazy is not acceptable".
But verify_signed_buffer() reads "gpg --status-fd=1 --verify"
output, it is already done lazily in format_commit_one() only when
the "%G?" placeholder is used, and the output we parse that are
prefixed by [GNUPG:] should have enough information to grab the
fingerprint from on the VALIDSIG line.
So I do not see a lot of room to screw-up the execution ;-).
next prev parent reply other threads:[~2015-01-16 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 16:57 Proper plumbing for porcelain gpg formats on git show? Jason Pyeron
2015-01-16 19:29 ` Jonathan Nieder
2015-01-16 19:52 ` Junio C Hamano [this message]
2015-01-16 20:05 ` Jason Pyeron
2015-01-19 14:13 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk30m1p0t.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jpyeron@pdinc$(echo .)us \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox