Subject: Re: [PATCH 09/18] fsck: handle multiple authors in commits specially

From: Junio C Hamano <[email-masked]>
Date: Wed, 10 Dec 2014 10:04:22 -0800

Johannes Schindelin <[email-masked]> writes:

> This problem has been detected in the wild, and is the primary reason
> to introduce an option to demote certain fsck errors to warnings. Let's
> offer to ignore this particular problem specifically.
> ...
> +	while (skip_prefix(buffer, "author ", &buffer)) {
> +		err = report(options, &commit->object, FSCK_MSG_MULTIPLE_AUTHORS, "invalid format - multiple 'author' lines");
> +		if (err)
> +			return err;

If we have an option to demote this to a warning, wouldn't we want
to do the same fsck_ident() on that secondary author line?

> +		/* require_end_of_header() ensured that there is a newline */
> +		buffer = strchr(buffer, '\n') + 1;
> +	}
>  	if (!skip_prefix(buffer, "committer ", &buffer))
>  		return report(options, &commit->object, FSCK_MSG_MISSING_COMMITTER, "invalid format - expected 'committer' line");
>  	err = fsck_ident(&buffer, &commit->object, options);