From: Junio C Hamano <gitster@pobox•com>
To: Eric Wong <normalperson@yhbt•net>
Cc: Luis Henriques <henrix@camandro•org>, git@vger•kernel.org
Subject: Re: [RFC][PATCH] send-email: add --[no-]xmailer option
Date: Wed, 03 Dec 2014 08:56:45 -0800 [thread overview]
Message-ID: <xmqqk328k6ya.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141203023419.GA10519@dcvr.yhbt.net> (Eric Wong's message of "Wed, 3 Dec 2014 02:34:19 +0000")
Eric Wong <normalperson@yhbt•net> writes:
> Luis Henriques <henrix@camandro•org> wrote:
>> On Mon, Mar 24, 2014 at 09:38:27PM +0000, Luis Henriques wrote:
>> > Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:'
>> > header to the email being sent.
>> >
>>
>> Ping
>>
>> It's been a while since I sent this patch. Is there any interest in
>> having this switch in git-send-email?
>
> I wasn't paying attention when the original was sent, but this
> looks good to me.
>
> Acked-by: Eric Wong <normalperson@yhbt•net>
>
>> I honestly don't like disclosing too much information about my system,
>> in this case which MUA I'm using and its version.
>
> Right on. I would even favor this being the default.
>
> Auto-generated Message-Id headers also shows the use of git-send-email;
> perhaps there can be a way to configure that, too. However,
> git-send-email respects manually-added Message-Id headers in the
> original patch, so it's less of a problem, I suppose.
I actually do not think this is a good idea from debuggability.
next prev parent reply other threads:[~2014-12-03 16:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 21:38 [RFC][PATCH] send-email: add --[no-]xmailer option Luis Henriques
2014-12-02 19:32 ` Luis Henriques
2014-12-03 2:34 ` Eric Wong
2014-12-03 3:22 ` Kyle J. McKay
2014-12-03 10:13 ` Luis Henriques
2014-12-03 16:56 ` Junio C Hamano [this message]
2014-12-04 19:22 ` Luis Henriques
2014-12-04 19:33 ` Junio C Hamano
2014-12-04 19:44 ` Luis Henriques
2014-12-03 17:08 ` Junio C Hamano
2014-12-03 17:23 ` Junio C Hamano
2014-12-03 17:39 ` Junio C Hamano
2014-12-03 18:02 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk328k6ya.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=henrix@camandro$(echo .)org \
--cc=normalperson@yhbt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox