From: Junio C Hamano <gitster@pobox•com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base
Date: Mon, 01 Dec 2014 11:32:15 -0800 [thread overview]
Message-ID: <xmqqk32bp3nk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1417338302-8208-2-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Sun, 30 Nov 2014 16:05:00 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail•com> writes:
> This allows the callback to use 'base' as a temporary buffer to
> quickly assemble full path "without" extra allocation. The callback
> has to restore it afterwards of course.
Hmph, what's the quote around 'without' doing there?
next prev parent reply other threads:[~2014-12-01 19:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 9:04 [PATCH 0/3] ls-tree fixes Nguyễn Thái Ngọc Duy
2014-11-30 9:05 ` [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base Nguyễn Thái Ngọc Duy
2014-12-01 19:32 ` Junio C Hamano [this message]
2014-12-02 12:11 ` Duy Nguyen
2014-12-03 0:11 ` Eric Sunshine
2014-12-03 16:13 ` Junio C Hamano
2014-12-08 13:30 ` Duy Nguyen
2014-11-30 9:05 ` [PATCH 2/3] ls-tree: remove path filtering logic in show_tree Nguyễn Thái Ngọc Duy
2014-11-30 9:05 ` [PATCH 3/3] ls-tree: disable negative pathspec because it's not supported Nguyễn Thái Ngọc Duy
2014-12-01 19:40 ` Junio C Hamano
2014-12-02 12:14 ` Duy Nguyen
-- strict thread matches above, loose matches on Subject: below --
2014-11-08 11:00 [PATCH 1/3] tree.c: update read_tree_recursive callback to pass strbuf as base Nguyễn Thái Ngọc Duy
2014-11-08 11:03 ` Duy Nguyen
2014-11-09 3:56 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk32bp3nk.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox