public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: 0xAX <kuleshovmail@gmail•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>,
	Alex Kuleshov <kuleshovmail@gmial•com>
Subject: Re: [PATCH 1/1] git-config: git-config --list fixed when GIT_CONFIG value starts with ~/
Date: Fri, 14 Nov 2014 12:10:16 -0800	[thread overview]
Message-ID: <xmqqk32x35nb.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1415989760-20259-1-git-send-email-kuleshovmail@gmail.com> (kuleshovmail@gmail.com's message of "Sat, 15 Nov 2014 00:29:20 +0600")

0xAX <kuleshovmail@gmail•com> writes:

> When we execute git config --list and $GIT_CONFIG value starts with home
> prefix - ~/ it produces folowing error - fatal: unable to read config
> file '~/.gitconfig': No such file or directory. This patch fixed it with
> expand_user_path for configuration file path before git-config --list
> call.

Expanding tilde ~ in environment variables is what you let your
shell do when you assign it.   This is not limited to Git:

    $ FOO=~/.bashrc
    $ BAR='~/.bashrc'
    $ head -n 1 "$FOO"
    # Bourne Again SHell init file.
    $ head -n 1 "$BAR"
    head: cannot open ‘~/.bashrc’ for reading: No such file rdirectory

    $ echo "FOO=$FOO" "BAR=$BAR"
    FOO=/home/gitster/.bashrc BAR=~/.bashrc

The patch does not fix anything and not necessary.

      parent reply	other threads:[~2014-11-14 20:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 18:29 [PATCH 1/1] git-config: git-config --list fixed when GIT_CONFIG value starts with ~/ 0xAX
2014-11-14 19:19 ` Eric Sunshine
2014-11-14 19:30   ` Jeff King
2014-11-14 19:38     ` Alex Kuleshov
2014-11-14 20:04       ` Jeff King
2014-11-14 20:10 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk32x35nb.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=kuleshovmail@gmail$(echo .)com \
    --cc=kuleshovmail@gmial$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox