From: Junio C Hamano <gitster@pobox•com>
To: Andreas Schwab <schwab@linux-m68k•org>
Cc: Jeff King <peff@peff•net>, Stepan Kasal <kasal@ucw•cz>,
Johannes Schindelin <Johannes.Schindelin@gmx•de>,
git@vger•kernel.org,
Jean-Jacques Lafay <jeanjacques.lafay@gmail•com>
Subject: Re: [PATCH v3] git tag --contains: avoid stack overflow
Date: Tue, 23 Sep 2014 15:41:09 -0700 [thread overview]
Message-ID: <xmqqk34ugdtm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <87wq8u3t4l.fsf@igel.home> (Andreas Schwab's message of "Tue, 23 Sep 2014 23:48:58 +0200")
Andreas Schwab <schwab@linux-m68k•org> writes:
> Jeff King <peff@peff•net> writes:
>
>> But if we do want to keep it, does bumping it to 128 (and bumping the
>> 4000 to 8000 in the test below it) work?
>
> It works for all architectures supported by the openSUSE build service.
>
> https://build.opensuse.org/package/show/home:AndreasSchwab:f/git
>
> Andreas.
So this on top of cbc60b67 (git tag --contains: avoid stack
overflow, 2014-04-24) and merge it to maint and upwards?
t/t7004-tag.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index e4ab0f5..c564197 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -1424,7 +1424,7 @@ EOF
'
run_with_limited_stack () {
- (ulimit -s 64 && "$@")
+ (ulimit -s 128 && "$@")
}
test_lazy_prereq ULIMIT 'run_with_limited_stack true'
@@ -1433,7 +1433,7 @@ test_lazy_prereq ULIMIT 'run_with_limited_stack true'
test_expect_success ULIMIT '--contains works in a deep repo' '
>expect &&
i=1 &&
- while test $i -lt 4000
+ while test $i -lt 8000
do
echo "commit refs/heads/master
committer A U Thor <author@example•com> $((1000000000 + $i * 100)) +0200
next prev parent reply other threads:[~2014-09-23 22:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 14:15 [PATCH] git tag --contains : avoid stack overflow Stepan Kasal
2014-04-16 15:46 ` Jeff King
2014-04-17 17:31 ` Johannes Schindelin
2014-04-17 21:32 ` Jeff King
2014-04-17 21:52 ` Johannes Schindelin
2014-04-17 21:58 ` Jeff King
2014-04-23 7:53 ` [PATCH v2] " Stepan Kasal
2014-04-23 14:28 ` Johannes Schindelin
2014-04-23 15:45 ` Stepan Kasal
2014-04-23 19:12 ` Junio C Hamano
2014-04-23 19:16 ` Jeff King
2014-04-23 20:48 ` Junio C Hamano
2014-04-23 20:55 ` Jeff King
2014-04-23 21:05 ` Junio C Hamano
2014-04-24 12:20 ` Stepan Kasal
2014-04-24 12:24 ` [PATCH v3] git tag --contains: " Stepan Kasal
2014-04-25 5:54 ` Jeff King
2014-09-20 18:18 ` Andreas Schwab
2014-09-23 16:05 ` Jeff King
2014-09-23 21:48 ` Andreas Schwab
2014-09-23 22:41 ` Junio C Hamano [this message]
2014-04-23 19:59 ` [PATCH v2] git tag --contains : " Stepan Kasal
2014-04-23 19:17 ` Jeff King
2014-04-23 21:14 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk34ugdtm.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=jeanjacques.lafay@gmail$(echo .)com \
--cc=kasal@ucw$(echo .)cz \
--cc=peff@peff$(echo .)net \
--cc=schwab@linux-m68k$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox