Subject: Re: [PATCH 1/4] completion: add missing terminator in case statement

From: Junio C Hamano <[email-masked]>
Date: Mon, 21 Jul 2014 13:09:13 -0700

Junio C Hamano <[email-masked]> writes:

> John Keeping <[email-masked]> writes:
>
>> Signed-off-by: John Keeping <[email-masked]>
>> ---
>
> As these ;; are separators not terminators, this is not strictly
> necessary.  Squashing it into a change that adds more case arms to
> this case statement is of course not just good but necessary,
> though.

s/necessary/may be &/; if you add new arms before this one, you
won't need it.  But if you add one after this, you would ;-).

>>  contrib/completion/git-completion.bash | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 7a6e1d7..d0b2895 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -1627,6 +1627,7 @@ _git_push ()
>>  	--repo)
>>  		__gitcomp_nl "$(__git_remotes)"
>>  		return
>> +		;;
>>  	esac
>>  	case "$cur" in
>>  	--repo=*)