From: Junio C Hamano <gitster@pobox•com>
To: Jeremiah Mahler <jmmahler@gmail•com>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: [PATCH v7 2/2] format-patch --signature-file <file>
Date: Wed, 21 May 2014 14:59:36 -0700 [thread overview]
Message-ID: <xmqqk39eoks7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1400706472-13471-3-git-send-email-jmmahler@gmail.com> (Jeremiah Mahler's message of "Wed, 21 May 2014 14:07:52 -0700")
Jeremiah Mahler <jmmahler@gmail•com> writes:
> + if (signature_file) {
> + if (signature && signature != git_version_string)
> + die(_("cannot specify both signature and signature-file"));
> +
> + struct strbuf buf = STRBUF_INIT;
builtin/log.c:1460:3: error: ISO C90 forbids mixed declarations and
code [-Werror=declaration-after-statement]
prev parent reply other threads:[~2014-05-21 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 21:07 [PATCH v7 0/2] format-patch --signature-file <file> Jeremiah Mahler
2014-05-21 21:07 ` [PATCH v7 1/2] format-patch: make newline after signature conditional Jeremiah Mahler
2014-05-21 21:22 ` Junio C Hamano
2014-05-21 21:07 ` [PATCH v7 2/2] format-patch --signature-file <file> Jeremiah Mahler
2014-05-21 21:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk39eoks7.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jmmahler@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox