From: Junio C Hamano <gitster@pobox•com>
To: Adrian Johnson <ajohnson@redneon•com>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>
Subject: Re: [PATCH v2] userdiff: update Ada patterns
Date: Wed, 05 Feb 2014 09:17:47 -0800 [thread overview]
Message-ID: <xmqqk3d95vic.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <52F2160D.1040006@redneon.com> (Adrian Johnson's message of "Wed, 05 Feb 2014 21:14:29 +1030")
Adrian Johnson <ajohnson@redneon•com> writes:
>>> - "|[0-9][-+0-9#_.eE]"
>>> + "|[-+]?[0-9][0-9#_.aAbBcCdDeEfF]*([eE][+-]?[0-9_]+)?"
>>
>> This would match a lot wider than what I read you said you wanted to
>> match in your previous message. Does "-04##4_3_2Ee-9" count as a
>> number, for example, or can we just ignore such syntactically
>> incorrect sequence?
>
> Maybe I am misunderstanding the purpose of the word diff regexes. I
> thought the purpose of the word regex is to split lines into words, not
> determine what is syntactically correct.
I agree that the purpose is former---So you could have just said
"the latter" ;-).
Any other nitpick, anybody? Otherwise I'll queue this version.
next prev parent reply other threads:[~2014-02-05 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 10:51 [PATCH] userdiff: update Ada patterns Adrian Johnson
2014-02-02 23:35 ` Jeff King
2014-02-03 11:30 ` Adrian Johnson
2014-02-03 11:33 ` [PATCH v2] " Adrian Johnson
2014-02-03 20:00 ` Junio C Hamano
2014-02-05 10:44 ` Adrian Johnson
2014-02-05 17:17 ` Junio C Hamano [this message]
2014-02-05 17:28 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2014-02-03 18:33 George Spelvin
2014-02-03 20:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk3d95vic.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=ajohnson@redneon$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox