From: Junio C Hamano <gitster@pobox•com>
To: Josh Triplett <josh@joshtriplett•org>
Cc: Christian Couder <chriscool@tuxfamily•org>,
git@vger•kernel.org, Johan Herland <johan@herland•net>,
Thomas Rast <tr@thomasrast•ch>,
Michael Haggerty <mhagger@alum•mit.edu>,
Dan Carpenter <dan.carpenter@oracle•com>,
Greg Kroah-Hartman <greg@kroah•com>, Jeff King <peff@peff•net>
Subject: Re: [PATCH 9/9] trailer: add tests for "git interpret-trailers"
Date: Mon, 30 Dec 2013 12:46:33 -0800 [thread overview]
Message-ID: <xmqqk3emqd7a.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131230202042.GJ27213@leaf> (Josh Triplett's message of "Mon, 30 Dec 2013 12:20:42 -0800")
Josh Triplett <josh@joshtriplett•org> writes:
> On Mon, Dec 30, 2013 at 09:19:55AM -0800, Junio C Hamano wrote:
>> Christian Couder <chriscool@tuxfamily•org> writes:
>>
>> > +# Do not remove trailing spaces below!
>> > +cat >complex_message_trailers <<'EOF'
>> > +Fixes:
>> > +Acked-by:
>> > +Reviewed-by:
>> > +Signed-off-by:
>> > +EOF
>>
>> Just a hint. I think it is far safer and robust over time to do
>> something like this:
>>
>> sed -e 's/ Z$/ /' <<-\EOF
>> Fixes: Z
>> Acked-by: Z
>> EOF
>>
>> instead of a comment, which can warn human developers but does not
>> do anything to prevent their editors' auto-fix features from kicking
>> in.
>
> This, but for simplicity, since every line needs the trailing space, why
> not just use 's/$/ /' and drop the ' Z' on every line?
>
> </bikeshed>
>
> - Josh Triplett
A few reasons:
- The "everybody will have a single SP at the end" may or may not
last forever;
- With your scheme, if you already had _one_ trailing SPs in the
input, it would be hard to spot in the source;
- It makes it visually very clear that we expect a SP after these
colons. This is especially true if you replace 'Z' with
something more readable (e.g. '|').
next prev parent reply other threads:[~2013-12-30 20:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 6:37 [PATCH 0/9] Add interpret-trailers builtin Christian Couder
2013-12-24 6:37 ` [PATCH 1/9] Add data structures and basic functions for commit trailers Christian Couder
2013-12-24 6:37 ` [PATCH 2/9] trailer: process trailers from file and arguments Christian Couder
2013-12-24 6:37 ` [PATCH 3/9] trailer: read and process config information Christian Couder
2013-12-24 13:47 ` Christian Couder
2013-12-24 6:37 ` [PATCH 4/9] trailer: process command line trailer arguments Christian Couder
2013-12-24 6:37 ` [PATCH 5/9] strbuf: add strbuf_isspace() Christian Couder
2013-12-24 6:37 ` [PATCH 6/9] trailer: parse trailers from input file Christian Couder
2013-12-24 6:37 ` [PATCH 7/9] trailer: put all the processing together and print Christian Couder
2013-12-24 6:37 ` [PATCH 8/9] trailer: add interpret-trailers command Christian Couder
2013-12-24 6:37 ` [PATCH 9/9] trailer: add tests for "git interpret-trailers" Christian Couder
2013-12-30 17:19 ` Junio C Hamano
2013-12-30 20:20 ` Josh Triplett
2013-12-30 20:46 ` Junio C Hamano [this message]
2013-12-30 20:52 ` Josh Triplett
2013-12-30 21:05 ` Junio C Hamano
2013-12-30 22:27 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk3emqd7a.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=greg@kroah$(echo .)com \
--cc=johan@herland$(echo .)net \
--cc=josh@joshtriplett$(echo .)org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=peff@peff$(echo .)net \
--cc=tr@thomasrast$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox