From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Michael S. Tsirkin" <mst@redhat•com>, git@vger•kernel.org
Subject: Re: [PATCH] git send-email: include [anything]-by: signatures
Date: Tue, 03 Sep 2013 14:39:05 -0700 [thread overview]
Message-ID: <xmqqk3ixpoue.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20130903210352.GA27344@sigill.intra.peff.net> (Jeff King's message of "Tue, 3 Sep 2013 17:03:52 -0400")
Jeff King <peff@peff•net> writes:
> On Wed, Sep 04, 2013 at 12:01:49AM +0300, Michael S. Tsirkin wrote:
>
>> > The question of course is the first point Peff raised. I am not
>> > sure offhand what the right per-project customization interface
>> > would be. A starting point might be something like:
>> >
>> > --cc-trailer=signed-off-by,acked-by,reviewed-by
>>
>> tested-by, reported-by ...
>
> Yeah, I think having the list customizable is nice, but not allowing
> some pattern matching seems unfriendly, as it requires the user to
> enumerate a potentially long list.
>
>> > --cc-trailer='*-by'
>> >
>> > and an obvious configuration variable that gives the default for it.
>> > That would eventually allow us not to special case any fixed set of
>> > trailers like S-o-b like the current code does, which would be a big
>> > plus.
>>
>> What bothers me is that git normally uses gawk based patterns,
>> but send-email is in perl so it has a different syntax for regexp.
>> What do you suggest? Make a small binary to do the matching for us?
>
> Would fnmatch-style globbing (like "*-by") be enough? That should be
> easy to do in perl.
Web query finds File::FnMatch; I do not know if that is the most
commonly used, or if it comes with the base distribution, though.
next prev parent reply other threads:[~2013-09-03 21:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 16:57 [PATCH] git send-email: include [anything]-by: signatures Michael S. Tsirkin
2013-08-31 19:22 ` Michael S. Tsirkin
2013-09-03 6:35 ` Jeff King
2013-09-03 8:44 ` Michael S. Tsirkin
2013-09-03 17:06 ` Junio C Hamano
2013-09-03 21:01 ` Michael S. Tsirkin
2013-09-03 21:03 ` Jeff King
2013-09-03 21:24 ` Michael S. Tsirkin
2013-09-03 21:39 ` Junio C Hamano [this message]
2013-09-04 8:09 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk3ixpoue.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox