Subject: Re: [PATCH 00/15] tests: don't ignore "git" exit codes

From: Junio C Hamano <[email-masked]>
Date: Thu, 03 Mar 2022 18:44:21 -0800

Ævar Arnfjörð Bjarmason <[email-masked]> writes:

> Yes, it returns the correct status code, but that doesn't help with
> (pseudo)code like:
>
> 	if (run_command("foo")) /* exits with e.g. 123 */
> 		die("oh no, foo failed"); /* exits with 128 */
>
> I should have said "code using run-command.c does not do that...",
> sorry.

Yeah, but even if callers of run_command() can tell "foo"
segfaulted, I do not think it is sensible to exit as if we
segfaulted (or, we _could_ actually die by segfaulting ourselves,
which is worse).