public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: santiago@nyu•edu
Cc: git@vger•kernel.org, peff@peff•net, sunshine@sunshineco•com,
	walters@verbum•org
Subject: Re: [PATCH v3 0/5] Add --format to tag verification
Date: Fri, 30 Sep 2016 16:28:47 -0700	[thread overview]
Message-ID: <xmqqlgy97ys0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160930221806.3398-1-santiago@nyu.edu> (santiago@nyu.edu's message of "Fri, 30 Sep 2016 18:18:01 -0400")

What is in the patch series looked more or less good to me.  Lukas's
sirname was still P in [3/5], a patch in [4/5] added an unnecssary
blank line before git_verify_tag_config() and also a local variable
declaration for "char *fmt_pretty" was indented funnily, but none of
these were something I couldn't fix up locally.

I however notice that there is no new tests to protect these two new
features from future breakages.  Perhaps you want to add some in
[6/5]?

Thanks.

next prev parent reply	other threads:[~2016-09-30 23:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30 22:18 [PATCH v3 0/5] Add --format to tag verification santiago
2016-09-30 22:18 ` [PATCH v3 1/5] gpg-interface, tag: add GPG_VERIFY_QUIET flag santiago
2016-09-30 22:18 ` [PATCH v3 2/5] ref-filter: add function to print single ref_array_item santiago
2016-09-30 23:12   ` Jakub Narębski
2016-10-01  1:33     ` Junio C Hamano
2016-09-30 22:18 ` [PATCH v3 3/5] tag: add format specifier to gpg_verify_tag santiago
2016-09-30 22:18 ` [PATCH v3 4/5] builtin/verify-tag: add --format to verify-tag santiago
2016-09-30 22:18 ` [PATCH v3 5/5] builtin/tag: add --format argument for tag -v santiago
2016-09-30 23:28 ` Junio C Hamano [this message]
2016-10-03 14:49   ` [PATCH v3 0/5] Add --format to tag verification Santiago Torres
2016-10-03 20:58     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlgy97ys0.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    --cc=santiago@nyu$(echo .)edu \
    --cc=sunshine@sunshineco$(echo .)com \
    --cc=walters@verbum$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox