From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>,
Lars Schneider <larsxschneider@gmail•com>
Subject: Re: [PATCH] t7406: fix breakage on OSX
Date: Wed, 10 Aug 2016 13:34:33 -0700 [thread overview]
Message-ID: <xmqqlh044b3a.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kb5Sy6rC1j8uLq+oCTfVVpan0tgat59yOJV20nFeRzSKQ@mail.gmail.com> (Stefan Beller's message of "Wed, 10 Aug 2016 12:03:52 -0700")
Stefan Beller <sbeller@google•com> writes:
> On Wed, Aug 10, 2016 at 11:27 AM, Junio C Hamano <gitster@pobox•com> wrote:
>> Stefan Beller <sbeller@google•com> writes:
>>
>>> On OSX `wc` prefixes the output of numbers with whitespace, such that
>>> the `commit_count` would be "SP <NUMBER>". When using that in
>>>
>>> git submodule update --init --depth=$commit_count
>>>
>>> the depth would be empty and the number is interpreted as the pathspec.
>>> Fix this by not using `wc` and rather instruct rev-list to count.
>>>
>>> Another way to fix this is to remove the `=` sign after the `--depth`
>>> argument as then we are allowed to have more than just one whitespace
>>> between `--depth` and the actual number. Prefer the solution of rev-list
>>> counting as that is expected to be slightly faster and more self-sustained
>>> within Git.
>>
>> You meant self-contained, I would guess.
>
> Yes. Mind to fix that locally, or waiting for a resend?
Fixed it up while queuing.
>> There are a couple of "log --oneline | wc -l" remaining that are
>> currently safe but they may be a time-bomb waiting to go off.
> ...
> All of the occurrences are not white space sensitive AFAICT,
> they are just bad examples, which may inspire others to follow
> that pattern.
Yup, I agree(d).
next prev parent reply other threads:[~2016-08-10 20:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 22:32 What's cooking in git.git (Aug 2016, #03; Mon, 8) Junio C Hamano
2016-08-08 23:02 ` Stefan Beller
2016-08-09 15:43 ` Junio C Hamano
2016-08-09 18:52 ` Elijah Newren
2016-08-09 19:03 ` Junio C Hamano
2016-08-10 12:13 ` Johannes Schindelin
2016-08-10 17:30 ` Lars Schneider
2016-08-10 17:36 ` Stefan Beller
2016-08-10 17:46 ` Lars Schneider
2016-08-10 17:49 ` Junio C Hamano
2016-08-10 17:56 ` [PATCH] t7406: fix breakage on OSX Stefan Beller
2016-08-10 18:27 ` Junio C Hamano
2016-08-10 19:03 ` Stefan Beller
2016-08-10 20:34 ` Junio C Hamano [this message]
2016-08-10 19:03 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlh044b3a.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=larsxschneider@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox